Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 23239 invoked from network); 3 Jun 2010 21:28:03 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 3 Jun 2010 21:28:03 -0000 Received: (qmail 90868 invoked by uid 500); 3 Jun 2010 21:28:03 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 90838 invoked by uid 500); 3 Jun 2010 21:28:03 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 90831 invoked by uid 99); 3 Jun 2010 21:28:03 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jun 2010 21:28:03 +0000 X-ASF-Spam-Status: No, hits=-1498.9 required=10.0 tests=ALL_TRUSTED,AWL X-Spam-Check-By: apache.org Received: from [140.211.11.9] (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 03 Jun 2010 21:28:03 +0000 Received: (qmail 23204 invoked from network); 3 Jun 2010 21:27:42 -0000 Received: from unknown (HELO ?IPv6:::1?) (127.0.0.1) by 127.0.0.1 with SMTP; 3 Jun 2010 21:27:42 -0000 Message-ID: <4C081E4D.6080308@apache.org> Date: Thu, 03 Jun 2010 23:27:41 +0200 From: Stefan Seelmann User-Agent: Thunderbird 2.0.0.24 (X11/20100411) MIME-Version: 1.0 To: Apache Directory Developers List Subject: Re: [ApacheDS] Move classes of module core-mock to src/test/java of core-api References: <4C0818EB.8010802@apache.org> <4C081A26.1060809@apache.org> In-Reply-To: <4C081A26.1060809@apache.org> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Felix Knecht wrote: > On 06/03/10 23:04, Stefan Seelmann wrote: >> Hi dev, > >> the core-mock module includes some mock implementations of ApacheDS >> core-api classes (CoreSession, DirectoryService, etc.). It is only used >> as test dependency in ldif-partition. > >> To get rid of the core-mock module I'd like to suggest to move those >> classes to src/test/java in core-api. To be able to use the test classes >> outside of the core-api module we just need to deploy the test jar of >> core-api. The using module then needs to specify a dependency with >> classifier "tests", see [1] for details. > >> Thoughts? > > +1 > > Regards > Felix Should we declare the deployment of test jar for the core-api module only or should we deploy the test jars of all modules? In the latter case we can declare the maven-jar-module in the project pom, similar to the maven-source-plugin. Kind Regards, Stefan