On Thu, Jun 3, 2010 at 8:36 PM, Emmanuel Lecharny <firstname.lastname@example.org> wrote:
On 6/3/10 7:08 PM, Felix Knecht wrote:Ok, in real world, this cache is just useless. I mean, it's a good idea to think about having a cache, but it has to be implemented correctly, which is not the case here.
-----BEGIN PGP SIGNED MESSAGE-----
The constructor accepts a cachesize which is never used. Apart of this I
really can't see, where the caching happens.
The discussions we had a while back about the caches (and there is a JIRA about it) demonstrated that we need a global cache, based on some global system like JCS (apache commons-jcs). It should be linked to the DirectryService, and mus not be a singleton.
Right now, the cache we have are associated with instances of the interceptors, so they are not shared. They are just valid during an user session, AFAICT. Not efficient... (I would ask you to take this with cautious, I may be wrong).