From dev-return-33991-apmail-directory-dev-archive=directory.apache.org@directory.apache.org Wed Jun 02 18:28:04 2010 Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 66426 invoked from network); 2 Jun 2010 18:28:03 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 2 Jun 2010 18:28:03 -0000 Received: (qmail 37032 invoked by uid 500); 2 Jun 2010 18:28:03 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 36844 invoked by uid 500); 2 Jun 2010 18:28:03 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 36837 invoked by uid 99); 2 Jun 2010 18:28:03 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Jun 2010 18:28:03 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Jun 2010 18:28:01 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o52IRd5Y012711 for ; Wed, 2 Jun 2010 18:27:39 GMT Message-ID: <1812981.139071275503259296.JavaMail.jira@thor> Date: Wed, 2 Jun 2010 14:27:39 -0400 (EDT) From: "Emmanuel Lecharny (JIRA)" To: dev@directory.apache.org Subject: [jira] Resolved: (DIRSERVER-833) Attribute(s)Impl usage and API In-Reply-To: <12221463.1169343089949.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DIRSERVER-833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emmanuel Lecharny resolved DIRSERVER-833. ----------------------------------------- Resolution: Fixed The Entry API has been completely reviewed last year. > Attribute(s)Impl usage and API > ------------------------------ > > Key: DIRSERVER-833 > URL: https://issues.apache.org/jira/browse/DIRSERVER-833 > Project: Directory ApacheDS > Issue Type: Task > Reporter: Emmanuel Lecharny > Fix For: 2.0.0-RC1 > > > We should modify the Attribute(s)Impl API and usage. Those classes should never be used outside of the server, and we should use BasicAttribute(s) instance instead. > When we receive a BasicAttribute(s) instance, we should convert them to an Attribute(s)Impl before working on attributes. > A second point is that operations like contains(), get() or equals() must use the matchingRules instead of doing straight comparizons of case sensitive strings. > Last, not least, we should not use the attribute name to do operations on attributes, but their OID. Operations like > "objectClass".equals( trim( attributeType.getName() ).toLowerCase ) > should not be used. It's much better to define a static final OBJECT_CLASS_OID somewhere and do a > OBJECT_CLASS_OID.equals( attributeType.getOid() ) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.