directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Lecharny <elecha...@gmail.com>
Subject Re: svn commit: r952265 - /directory/apacheds/trunk/jdbm/src/main/java/jdbm/btree/BTree.java
Date Mon, 07 Jun 2010 16:20:54 GMT
On 6/7/10 6:02 PM, Felix Knecht wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 06/07/10 17:51, Felix Knecht wrote:
>    
>>      
>>> Yes, this is the other option : not checking the keySerializer at all,
>>> as the test always evaluate to true. But certainly not checking half of
>>> the test (ie if ( keySerilizer != null ) then throw Exception),
>>> otherwise, trust me, you'll get tens of failing tests !!
>>>        
> Either we throw an Exception when they are null or we can drop the 2 if
> classes, do you agree?
>    

Atm, I don't know if it's OK to have null serializers... Anyway, it's 
not tested, so let's drop the if tests.

-- 
Regards,
Cordialement,
Emmanuel L├ęcharny
www.nextury.com



Mime
View raw message