directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Lecharny <elecha...@gmail.com>
Subject Re: svn commit: r951912 - in /directory/apacheds/trunk: protocol-ntp/src/test/java/org/apache/directory/server/ntp/NtpITest.java server-xml/ xbean-spring/
Date Sun, 06 Jun 2010 18:56:26 GMT
On 6/6/10 8:17 PM, Stefan Seelmann wrote:
> Emmanuel Lecharny wrote:
>    
>> On 6/6/10 8:01 PM, Stefan Seelmann wrote:
>>      
>>>        
>>>> @@ -74,6 +75,7 @@ public class NtpITest
>>>>         * @throws Exception if there are errors
>>>>         */
>>>>        @Test
>>>> +    @Ignore
>>>>        public void testNtp() throws Exception
>>>>        {
>>>>            InetAddress host = InetAddress.getByName( null );
>>>>
>>>>
>>>>          
>>> Is this intended? I though I fixed this test yesterday, is it still
>>> failing?
>>>
>>>        
>> No, sorry, it was caught in a big commit I did. I will revert it
>> immediately.
>>
>> Btw, what was the problem ?--
>>      
> The test asserted two things:
>
> - the delay is in range 0..1000 ms, both bounds excluded. But the delay
> could be 0, especially when getting the time from localhost without any
> network roundtrip. So I included the 0 as valid value.
>
> - the offset is in range 0..1000 ms, both bounds excluded. But the
> offset can be negative. Now the test checks that offset is in range
> -1000..1000 ms.
>    
Doh...

yeah, smart. I didn't thought it can be such a simple problem...

Thank for the fix Stefan !


-- 
Regards,
Cordialement,
Emmanuel L├ęcharny
www.nextury.com



Mime
View raw message