directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Felix Knecht <fel...@apache.org>
Subject Re: Code is never executed
Date Fri, 04 Jun 2010 14:40:07 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/04/10 16:32, Emmanuel Lecharny wrote:
> On 6/4/10 4:14 PM, Felix Knecht wrote:
>> This will always match for the else clause - we now the attributeType is
>> null (line 1469). Probably dead code?
>>
>> http://people.apache.org/~felixk/shared-docs/xref/org/apache/directory/shared/ldap/entry/DefaultEntryAttribute.html#1475
>>
>>    
> 
> Dohhh ! Good catch again :)

Well, is it dead code now?

> 
> I will soon think that code reviews should be mandatory :)

The tools are already doing this for us. I just seem to be the one ATM (
... as I have still not much knowledge of the code ...) looking at the
reports which are generated.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkwJEEcACgkQ2lZVCB08qHF11gCgpw0dWygqevU3sos8m5kqDR1j
l5cAn2o553g8lgUE4KXoVjj130LK+n23
=NSVr
-----END PGP SIGNATURE-----

Mime
View raw message