directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pierre-Arnaud Marcelot ...@marcelot.net>
Subject Re: svn commit: r947413 - in /directory/shared/trunk/ldap: pom.xml src/main/java/org/apache/directory/shared/ldap/codec/LdapTransformer.java
Date Tue, 01 Jun 2010 15:43:55 GMT
Hi Felix,

I'm currently reviewing the dependency tree of each project in Apache DS.

When generating the installers I've found a lot of new dependencies (since the last release)
in the generated lib folder, and especially this one: findbugs:annotations.

Are you sure of the scope of this dependency?
Shouldn't it be defined as "provided" (this way it won't be passed on transitively)?

Thanks,
Pierre-Arnaud


On 23 mai 2010, at 15:46, felixk@apache.org wrote:

> Author: felixk
> Date: Sun May 23 13:46:14 2010
> New Revision: 947413
> 
> URL: http://svn.apache.org/viewvc?rev=947413&view=rev
> Log:
> False positive
> 
> Modified:
>    directory/shared/trunk/ldap/pom.xml
>    directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/LdapTransformer.java
> 
> Modified: directory/shared/trunk/ldap/pom.xml
> URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/pom.xml?rev=947413&r1=947412&r2=947413&view=diff
> ==============================================================================
> --- directory/shared/trunk/ldap/pom.xml (original)
> +++ directory/shared/trunk/ldap/pom.xml Sun May 23 13:46:14 2010
> @@ -76,6 +76,13 @@
>       <artifactId>antlr</artifactId>
>       <version>${antlr.version}</version>
>     </dependency>
> +
> +    <dependency>
> +      <groupId>findbugs</groupId>
> +      <artifactId>annotations</artifactId>
> +      <version>${findbugs.annotations.version}</version>
> +      <scope>compile</scope>
> +    </dependency>
>   </dependencies>
> 
>   <build>
> 
> Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/LdapTransformer.java
> URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/LdapTransformer.java?rev=947413&r1=947412&r2=947413&view=diff
> ==============================================================================
> --- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/LdapTransformer.java
(original)
> +++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/LdapTransformer.java
Sun May 23 13:46:14 2010
> @@ -1242,6 +1242,8 @@ public class LdapTransformer
>      * @param msg the message to transform
>      * @return the msg transformed
>      */
> +    @edu.umd.cs.findbugs.annotations.SuppressWarnings(value="NP_NULL_ON_SOME_PATH",
> +        justification="The number of Ldap Message we are dealing with is finite, and
we won't ever have to deal with any other unexpected one")
>     public static Object transform( InternalMessage msg )
>     {
>         if ( IS_DEBUG )
> 
> 


Mime
View raw message