Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 25460 invoked from network); 22 May 2010 04:52:13 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 22 May 2010 04:52:13 -0000 Received: (qmail 44387 invoked by uid 500); 22 May 2010 04:52:13 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 44251 invoked by uid 500); 22 May 2010 04:52:11 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 44244 invoked by uid 99); 22 May 2010 04:52:10 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 May 2010 04:52:10 +0000 X-ASF-Spam-Status: No, hits=0.5 required=10.0 tests=AWL,RCVD_IN_DNSWL_NONE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [62.179.121.36] (HELO viefep16-int.chello.at) (62.179.121.36) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 May 2010 04:52:04 +0000 Received: from edge05.upcmail.net ([192.168.13.212]) by viefep16-int.chello.at (InterMail vM.8.01.02.02 201-2260-120-106-20100312) with ESMTP id <20100522045137.NAEL1493.viefep16-int.chello.at@edge05.upcmail.net> for ; Sat, 22 May 2010 06:51:37 +0200 Received: from [192.168.1.50] ([84.74.100.246]) by edge05.upcmail.net with edge id LUrb1e02S5JxopQ05UrctA; Sat, 22 May 2010 06:51:37 +0200 X-SourceIP: 84.74.100.246 Message-ID: <4BF762CF.4090709@apache.org> Date: Sat, 22 May 2010 06:51:27 +0200 From: Felix Knecht Reply-To: felixk@apache.org User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100509 Thunderbird/3.0.4 MIME-Version: 1.0 To: dev@directory.apache.org Subject: Re: svn commit: r947213 - in /directory/apacheds/trunk: jdbm-store/src/main/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmTable.java jdbm/src/main/java/jdbm/btree/BPage.java jdbm/src/main/java/jdbm/btree/BTree.java References: <20100521230743.67E502388903@eris.apache.org> In-Reply-To: <20100521230743.67E502388903@eris.apache.org> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Cloudmark-Analysis: v=1.1 cv=KBHyIoyMIRH440NzHl6uMYpbxJngTLC2P1JzLC/QbPg= c=1 sm=0 a=ilhmIz5vG2AA:10 a=ygRHs6EKU7oA:10 a=pXoq77xVGrQA:10 a=IkcTkHD0fZMA:10 a=mV9VRH-2AAAA:8 a=xe8BsctaAAAA:8 a=b3SA_FMb1HuOe5A4dOIA:9 a=nwraoJPZbYGr1VlrTT0A:7 a=UMYcC9P41Z8G1YAFMolnGuhMYdUA:4 a=QEXdDO2ut3YA:10 a=88iI8knYSJUA:10 a=HpAAvcLHHh0Zw7uRqdWCyQ==:117 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Well.... ;-) it was again one of those early morning commits which made compilation failing. Fix in 947213 On 05/22/10 01:07, elecharny@apache.org wrote: > Author: elecharny > Date: Fri May 21 23:07:42 2010 > New Revision: 947213 > > URL: http://svn.apache.org/viewvc?rev=947213&view=rev > Log: > o Added some more generics > o Minor refactoring > > Modified: > directory/apacheds/trunk/jdbm-store/src/main/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmTable.java > directory/apacheds/trunk/jdbm/src/main/java/jdbm/btree/BPage.java > directory/apacheds/trunk/jdbm/src/main/java/jdbm/btree/BTree.java > > Modified: directory/apacheds/trunk/jdbm-store/src/main/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmTable.java > URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/jdbm-store/src/main/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmTable.java?rev=947213&r1=947212&r2=947213&view=diff > ============================================================================== > --- directory/apacheds/trunk/jdbm-store/src/main/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmTable.java (original) > +++ directory/apacheds/trunk/jdbm-store/src/main/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmTable.java Fri May 21 23:07:42 2010 > @@ -176,7 +176,7 @@ public class JdbmTable implements T > // marshallers. > > bt = new BTree( recMan, keyComparator, keySerializer, null ); > - recId = bt.getRecid(); > + recId = bt.getRecordId(); > recMan.setNamedObject( name, recId ); > recId = recMan.insert( 0 ); > recMan.setNamedObject( name + SZSUFFIX, recId ); > @@ -244,7 +244,7 @@ public class JdbmTable implements T > else > { > bt = new BTree( recMan, keyComparator, keySerializer, valueSerializer ); > - recId = bt.getRecid(); > + recId = bt.getRecordId(); > recMan.setNamedObject( name, recId ); > recId = recMan.insert( 0 ); > recMan.setNamedObject( name + SZSUFFIX, recId ); > @@ -648,7 +648,7 @@ public class JdbmTable implements T > if ( set.size() > numDupLimit ) > { > BTree tree = convertToBTree( set ); > - BTreeRedirect redirect = new BTreeRedirect( tree.getRecid() ); > + BTreeRedirect redirect = new BTreeRedirect( tree.getRecordId() ); > bt.insert( key, (V)BTreeRedirectMarshaller.INSTANCE.serialize( redirect ), true ); > > if ( LOG.isDebugEnabled() ) > @@ -780,7 +780,7 @@ public class JdbmTable implements T > { > ArrayTree avlTree = convertToArrayTree( tree ); > bt.insert( key, (V)marshaller.serialize( avlTree ), true ); > - recMan.delete( tree.getRecid() ); > + recMan.delete( tree.getRecordId() ); > } > > count--; > @@ -854,8 +854,8 @@ public class JdbmTable implements T > LOG.debug( "<--- Remove BTree {} = {}", name, key ); > } > > - recMan.delete( tree.getRecid() ); > - duplicateBtrees.remove( tree.getRecid() ); > + recMan.delete( tree.getRecordId() ); > + duplicateBtrees.remove( tree.getRecordId() ); > return; > } > else > @@ -1115,17 +1115,17 @@ public class JdbmTable implements T > } > > > - private BTree convertToBTree( ArrayTree arrayTree ) throws Exception > + private BTree convertToBTree( ArrayTree arrayTree ) throws Exception > { > - BTree bTree; > + BTree bTree; > > if ( valueSerializer != null ) > { > - bTree = new BTree( recMan, valueComparator, valueSerializer, null ); > + bTree = new BTree( recMan, valueComparator, valueSerializer, null ); > } > else > { > - bTree = new BTree( recMan, valueComparator ); > + bTree = new BTree( recMan, valueComparator ); > } > > Cursor keys = new ArrayTreeCursor( arrayTree ); > @@ -1133,7 +1133,7 @@ public class JdbmTable implements T > > while ( keys.next() ) > { > - bTree.insert( keys.get(), StringTools.EMPTY_BYTES, true ); > + bTree.insert( keys.get(), (K)StringTools.EMPTY_BYTES, true ); > } > > return bTree; > > Modified: directory/apacheds/trunk/jdbm/src/main/java/jdbm/btree/BPage.java > URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/jdbm/src/main/java/jdbm/btree/BPage.java?rev=947213&r1=947212&r2=947213&view=diff > ============================================================================== > --- directory/apacheds/trunk/jdbm/src/main/java/jdbm/btree/BPage.java (original) > +++ directory/apacheds/trunk/jdbm/src/main/java/jdbm/btree/BPage.java Fri May 21 23:07:42 2010 > @@ -88,7 +88,7 @@ public final class BPage implement > final static long serialVersionUID = 1L; > > /** Parent B+Tree. */ > - transient BTree btree; > + transient BTree btree; > > /** This BPage's record ID in the PageManager. */ > protected transient long recid; > @@ -888,7 +888,7 @@ public final class BPage implement > } > > > - private final int compare( Object value1, Object value2 ) > + private final int compare( K value1, K value2 ) > { > if ( value1 == value2 ) > { > @@ -905,7 +905,7 @@ public final class BPage implement > return -1; > } > > - return btree.comparator.compare( value1, value2 ); > + return btree.getComparator().compare( value1, value2 ); > } > > > @@ -998,14 +998,14 @@ public final class BPage implement > > > /** > - * Assert the ordering of the keys on the BPage. This is used for testing > + * Assert the ordering of the keys on the BPage. This is used for testing > * purposes only. > */ > private void assertConsistency() > { > for ( int i = first; i < btree.pageSize - 1; i++ ) > { > - if ( compare( ( byte[] ) keys[i], ( byte[] ) keys[i + 1] ) >= 0 ) > + if ( compare( keys[i], keys[i + 1] ) >= 0 ) > { > dump( 0 ); > throw new Error( I18n.err( I18n.ERR_515 ) ); > @@ -1033,7 +1033,7 @@ public final class BPage implement > > BPage child = childBPage( i ); > > - if ( compare( ( byte[] ) keys[i], child.getLargestKey() ) != 0 ) > + if ( compare( keys[i], child.getLargestKey() ) != 0 ) > { > dump( 0 ); > child.dump( 0 ); > > Modified: directory/apacheds/trunk/jdbm/src/main/java/jdbm/btree/BTree.java > URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/jdbm/src/main/java/jdbm/btree/BTree.java?rev=947213&r1=947212&r2=947213&view=diff > ============================================================================== > --- directory/apacheds/trunk/jdbm/src/main/java/jdbm/btree/BTree.java (original) > +++ directory/apacheds/trunk/jdbm/src/main/java/jdbm/btree/BTree.java Fri May 21 23:07:42 2010 > @@ -107,7 +107,7 @@ public class BTree implements Exte > private transient long recordId; > > /** Comparator used to index entries. */ > - protected Comparator comparator; > + private Comparator comparator; > > /** Serializer used to serialize index keys (optional) */ > protected Serializer keySerializer; > @@ -149,7 +149,7 @@ public class BTree implements Exte > * @param recman Record manager used for persistence. > * @param comparator Comparator used to order index entries > */ > - public BTree( RecordManager recman, Comparator comparator ) throws IOException > + public BTree( RecordManager recman, Comparator comparator ) throws IOException > { > createInstance( recman, comparator, null, null, DEFAULT_SIZE ); > } > @@ -163,7 +163,7 @@ public class BTree implements Exte > * @param valueSerializer Serializer used to serialize index values (optional) > * @param comparator Comparator used to order index entries > */ > - public BTree( RecordManager recman, Comparator comparator, Serializer keySerializer, > + public BTree( RecordManager recman, Comparator comparator, Serializer keySerializer, > Serializer valueSerializer ) throws IOException > { > createInstance( recman, comparator, keySerializer, valueSerializer, DEFAULT_SIZE ); > @@ -179,7 +179,7 @@ public class BTree implements Exte > * @param valueSerializer Serializer used to serialize index values (optional) > * @param pageSize Number of entries per page (must be even). > */ > - public BTree( RecordManager recman, Comparator comparator, Serializer keySerializer, > + public BTree( RecordManager recman, Comparator comparator, Serializer keySerializer, > Serializer valueSerializer, int pageSize ) throws IOException > { > createInstance( recman, comparator, keySerializer, valueSerializer, pageSize ); > @@ -189,7 +189,7 @@ public class BTree implements Exte > /** > * The real BTree constructor. > */ > - private void createInstance(RecordManager recman, Comparator comparator, Serializer keySerializer, > + private void createInstance(RecordManager recman, Comparator comparator, Serializer keySerializer, > Serializer valueSerializer, int pageSize) throws IOException > { > if ( recman == null ) > @@ -528,7 +528,7 @@ public class BTree implements Exte > /** > * Return the persistent record identifier of the BTree. > */ > - public long getRecid() > + public long getRecordId() > { > return recordId; > } > @@ -557,7 +557,7 @@ public class BTree implements Exte > */ > public void readExternal( ObjectInput in ) throws IOException, ClassNotFoundException > { > - comparator = ( Comparator ) in.readObject(); > + comparator = ( Comparator ) in.readObject(); > keySerializer = ( Serializer ) in.readObject(); > valueSerializer = ( Serializer ) in.readObject(); > bTreeHeight = in.readInt(); > @@ -608,7 +608,7 @@ public class BTree implements Exte > /** > * @return the comparator > */ > - public Comparator getComparator() > + public Comparator getComparator() > { > return comparator; > } > > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkv3Ys8ACgkQ2lZVCB08qHHAzwCg29KXmAqtFdJJSCwtCoUpFoiK S9AAoKQbsQLAaYe5A5p16eEFxqaOTB+W =CGKP -----END PGP SIGNATURE-----