Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Received-SPF: neutral (nike.apache.org: local policy)
Message-ID: <4BF6441B.8060203@apache.org>
Date: Fri, 21 May 2010 10:28:11 +0200
From: Felix Knecht <felixk@apache.org>
Reply-To: felixk@apache.org
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
 rv:1.9.1.9) Gecko/20100509 Thunderbird/3.0.4
MIME-Version: 1.0
To: Apache Directory Developers List <dev@directory.apache.org>
Subject: Re: equals() implementation in ProtectedItem
References: <4BF528A7.9060006@otego.com> <4BF62BFC.30705@apache.org>
In-Reply-To: <4BF62BFC.30705@apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>> Are you aware, that this [1] is an equal of collections and will return
>> in most cases "false" as it is a reference comparison [2]?

Thanks to test cases :)
> 
> I checked the history. Previously we didn't use
>   Collections.unmodifiableCollection( attributeTypes )
> And a quick check shows that the callers of the construtor always pass
> an java.util.Set.
> 
> For two Sets the equals method would work correctly, but the creation of
> the unmodifyalbe collection not.
> 
> I think we have two options:
> - use CollectionUtils.isEqualCollection() from commons collections, this
> seems to do the right thing.
> - try to change the parameter type from Collection to Set in the
> constructors and use Collections.unmodifiableSet() instead.
> 
> Thoughts?

It dependes on the content we have in the collections. Set doesn't
allows duplicates wheras with certain collection implementations this is
possible.

>> [1]
>> http://people.apache.org/~felixk/shared-docs/xref/org/apache/directory/shared/ldap/aci/ProtectedItem.html#245
>> [2]
>> http://java.sun.com/j2se/1.5.0/docs/api/java/util/Collection.html#equals%28java.lang.Object%29
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkv2RBsACgkQ2lZVCB08qHEMRwCgqw/vU0yLW9MLaxJu84yseUiO
LtwAn0L5ez3u/jYUA0CIkfsT68qi371a
=hQz9
-----END PGP SIGNATURE-----