Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Received-SPF: pass (nike.apache.org: domain of elecharny@gmail.com designates
 74.125.82.178 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:reply-to:user-agent:mime-version:to:subject
         :references:in-reply-to:content-type:content-transfer-encoding;
        b=VF/Aw3pXj0lRjx5KhXcyzeRcqlA0NU3bjYN8iR4NeGHXuZ1G2r7jkGzCC0ELgtObNy
         3bknkDgI3Wo29P0FQMvrbU4wzrF0y0wEhNNc/9iKJhzjT6OB9klt4BYIwQ2fi/+JxCxe
         ex8uHoq98jbW0mRJWwsaZypea4YpS0RJMPcOI=
Message-ID: <4BF178B3.8040604@gmail.com>
Date: Mon, 17 May 2010 19:11:15 +0200
From: Emmanuel Lecharny <elecharny@gmail.com>
Reply-To: elecharny@apache.org
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US;
 rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4
MIME-Version: 1.0
To: Apache Directory Developers List <dev@directory.apache.org>
Subject: Re: shared.ldap.ldif.LdifEntry.equals not logic
References: <4BF1720B.6060201@otego.com>
In-Reply-To: <4BF1720B.6060201@otego.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

On 5/17/10 6:42 PM, Felix Knecht wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Sorry, it's me again ...
>    
Nah, that's a great job you are doing ! Good for the code, good for the 
project !
> On line 764 [1] we do 'entry.getDn()' and further down 784 [2] we check
> if entry==null.
> This check is not necessary, because line 764 will throw a NPE in this
> case what is very bad for an equals method. Maybe I'm wrong, but could
> line 764 also look like
>
> if(getEntry()==null) return false;
> DN thisDn = getEntry().getDn();
>    

Ouchh... Good catch. Yeah, obvioulsy the code is wrong.

-- 
Regards,
Cordialement,
Emmanuel L�charny
www.nextury.com