Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 20536 invoked from network); 15 May 2010 11:28:44 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 15 May 2010 11:28:44 -0000 Received: (qmail 3182 invoked by uid 500); 15 May 2010 11:28:44 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 3124 invoked by uid 500); 15 May 2010 11:28:43 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 3116 invoked by uid 99); 15 May 2010 11:28:43 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 15 May 2010 11:28:43 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=FREEMAIL_FROM,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of elecharny@gmail.com designates 74.125.82.178 as permitted sender) Received: from [74.125.82.178] (HELO mail-wy0-f178.google.com) (74.125.82.178) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 15 May 2010 11:28:35 +0000 Received: by wyj26 with SMTP id 26so818241wyj.37 for ; Sat, 15 May 2010 04:28:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:reply-to :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=Mo3o1bVkkNvZAK0/vnVm+WKEY7E5ES56i+LL2N2GHIs=; b=h2J3w/ThI46d2IEmGlV+svLVHyifhYyyK/CM0f2JC0Y3RW1fgf+FA5koUPQY/iNCbS BcW5yii990CspkJBJrq+zS1GWdD3N2jQpOt8K2Wz5B8QNKw/dl00lSIGxZl3zae7C390 Ng1WuO0KFWEFtl8nIa8Ol7QIvmFtmQsv2qlH0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:reply-to:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; b=gnhBYJr0VJBEXxeuft1vDfKVCQHAsvBVroDOOv76gBxdDHcITgQ7Ps5qxtU9MH8tHh NzLeONa7E/fJps+lTPiFrw4nLMC9yLSPr0YJdW629s1eFCuIEzNZRWG2Ag6NDwckx1s8 dCEuELGYErXEBY40PqDqJXlEQ/W6BN6DDarts= Received: by 10.227.136.72 with SMTP id q8mr2362785wbt.197.1273922895046; Sat, 15 May 2010 04:28:15 -0700 (PDT) Received: from emmanuel-lecharnys-MacBook-Pro.local (vol75-3-82-66-216-176.fbx.proxad.net [82.66.216.176]) by mx.google.com with ESMTPS id p29sm10580047wbe.22.2010.05.15.04.28.14 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 15 May 2010 04:28:14 -0700 (PDT) Message-ID: <4BEE8550.5080908@gmail.com> Date: Sat, 15 May 2010 13:28:16 +0200 From: Emmanuel Lecharny Reply-To: elecharny@apache.org User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4 MIME-Version: 1.0 To: Apache Directory Developers List Subject: Re: Equals and HashCode References: <4BEE5CE2.90002@otego.com> In-Reply-To: <4BEE5CE2.90002@otego.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org On 5/15/10 10:35 AM, Felix Knecht wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > We have a quite a lot of the following findings: > > HE: Class defines equals() and uses Object.hashCode() > (HE_EQUALS_USE_HASHCODE) > See [1], ... > > Do we consider them all as false positives or should we override the > hashCode function? > Definitively not a false positive. Implementing the equals() method does not works if we don't implement hashcade() at the same time. -- Regards, Cordialement, Emmanuel L�charny www.nextury.com