From dev-return-33401-apmail-directory-dev-archive=directory.apache.org@directory.apache.org Sat May 15 08:36:54 2010 Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 92125 invoked from network); 15 May 2010 08:36:54 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 15 May 2010 08:36:54 -0000 Received: (qmail 15975 invoked by uid 500); 15 May 2010 08:36:54 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 15851 invoked by uid 500); 15 May 2010 08:36:53 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 15842 invoked by uid 99); 15 May 2010 08:36:53 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 15 May 2010 08:36:53 +0000 X-ASF-Spam-Status: No, hits=0.3 required=10.0 tests=AWL,FREEMAIL_FROM,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of elecharny@gmail.com designates 74.125.82.178 as permitted sender) Received: from [74.125.82.178] (HELO mail-wy0-f178.google.com) (74.125.82.178) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 15 May 2010 08:36:46 +0000 Received: by wyj26 with SMTP id 26so764996wyj.37 for ; Sat, 15 May 2010 01:36:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:reply-to :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=2wTkUZSe3/iffNJevdDyS4BN2gLDgYRRsjc0CKx3rB0=; b=Xcumsfuvb6j4P8FFVOQsgJsdw9Sy5RTsnZj2yrQ68v8PQDK+U8Wv+VMRSjPi5g+REd pDiKA5IBAcaIsYu2tqlabGjpJsagVefh+j6ICqNEvpwdDUe8Z67OnrqFfKTg2gxpjI4j EZ4oUxSjSDr2vTEUqCpZGzRk3CcW9ZfzAXs3w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:reply-to:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; b=xe8fdgjW+xAlrzqvp0mpfDYR8Mxc+7YNkWfw6JIGZYV7yBb3pETyfFAC7aGlqMnjF9 n4qjd1xgRV4mUNbRanNSqRlUU/8hbGI6HaPwECL17cf9FpVE5xzC18nHjWIPpVET58+L /J8hPOZSqTTbGIKCDmZFk/BgKjOP29VAfzAUM= Received: by 10.227.127.132 with SMTP id g4mr2212600wbs.177.1273912585049; Sat, 15 May 2010 01:36:25 -0700 (PDT) Received: from emmanuel-lecharnys-MacBook-Pro.local (ver78-3-89-80-150-189.dsl.club-internet.fr [89.80.150.189]) by mx.google.com with ESMTPS id l23sm22850428wbb.20.2010.05.15.01.36.24 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 15 May 2010 01:36:24 -0700 (PDT) Message-ID: <4BEE5D0A.1010906@gmail.com> Date: Sat, 15 May 2010 10:36:26 +0200 From: Emmanuel Lecharny Reply-To: elecharny@apache.org User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4 MIME-Version: 1.0 To: dev@directory.apache.org Subject: Re: svn commit: r944590 - in /directory/apacheds/trunk: core-api/src/main/java/org/apache/directory/server/core/interceptor/ core/src/main/java/org/apache/directory/server/core/ core/src/main/java/org/apache/directory/server/core/changelog/ core/src/main/j... References: <20100515080609.33FC72388978@eris.apache.org> In-Reply-To: <20100515080609.33FC72388978@eris.apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 5/15/10 10:06 AM, felixk@apache.org wrote: > Author: felixk > Date: Sat May 15 08:06:07 2010 > New Revision: 944590 > > URL: http://svn.apache.org/viewvc?rev=944590&view=rev > Log: > > From PMD report "Avoid empty catch blocks" > I would not add a @SuppressWarning for such a warning. It's not good to have an empty catch block, and we should at least add a comment (// expected) if it's really expected, or add some real log if not. I don't think that an empty catch block is a good thing (except in tests) -- Regards, Cordialement, Emmanuel Lécharny www.nextury.com