directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Felix Knecht <fel...@apache.org>
Subject Re: Checkstyle report
Date Sun, 30 May 2010 17:26:47 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I added the custom configuration for most checkstyle reports (except
studio) and updated the reports for shared and apacheds. Please add or
comment specific checks in the custom config file
(https://svn.apache.org/repos/asf/directory/buildtools/trunk/checkstyle/src/main/resources/directory-checks.xml).

Regards
Felix

On 05/27/10 09:53, Emmanuel Lecharny wrote:
> Hi !
> 
> looking at shared checkstyle report this morning, I'm afraid that we
> need to tune the configuration. shared-ldap contains more than 84000
> violations, most of them being about { and } position and trailing spaces.
> 
> We can get rid of those useless warnings by tuning our checkstyle
> config, using our own configuration, assuming we are not following Sun's
> rules. I saw that there are existing config files available here :
> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/?pathrev=657536
> 
> 
> It would be interesting to have our own parameters for the following
> elements :
> ParenPad (38765 errors)
> RegexpSingleline (12689 errors) (this is about trailing spaces)
> LeftCurly (9104 errors)
> LineLength (6489 errors) -> set it to 128
> MagicNumber (3512 errors) -> remove simple numbers like 1, 2 etc
> FinalParameters (2746 errors)
> DesignForExtension (2134 errors)
> RightCurly (1388 errors)
> 
> Doing so, we will have 6360 errors remaining, out of which half are
> Javadoc errors.
> thoughts ?
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkwCn9YACgkQ2lZVCB08qHE2mQCfcNIUntldw0Ew0g5NYKwLx1jc
dvMAnj0wcLcJ6D6dgM6LBuYvmL9tUQer
=Z4pz
-----END PGP SIGNATURE-----

Mime
View raw message