directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Lecharny <elecha...@gmail.com>
Subject Re: Checkstyle report
Date Thu, 27 May 2010 13:26:24 GMT
On 5/27/10 1:30 PM, Felix Knecht wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 05/27/10 09:53, Emmanuel Lecharny wrote:
>    
>> Hi !
>>
>> looking at shared checkstyle report this morning, I'm afraid that we
>> need to tune the configuration. shared-ldap contains more than 84000
>> violations, most of them being about { and } position and trailing spaces.
>>
>> We can get rid of those useless warnings by tuning our checkstyle
>> config, using our own configuration, assuming we are not following Sun's
>> rules. I saw that there are existing config files available here :
>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/?pathrev=657536
>>      
> To have our custom checkstyle configuration there seems the need of
> having a module containing the configuration
> (http://maven.apache.org/plugins/maven-checkstyle-plugin/examples/multi-module-config.html).
> Do we put this into a new project on its own (e.g.
> directory/build-tools) and be able to use the same checkstyle
> configuration for all directory projects or do we add the build-tools
> module to every project wanted and have (jsut in case) different
> checkstyle configurations for different directory projects?
>    

Can't we use the 'project' module for that ?

Otherwise, I would say put it in each module (ie shared, ldap-api, 
daemon, installers and apacheds) using the same config.
> WDYT?
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.15 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkv+V9EACgkQ2lZVCB08qHFZLACgzAsJFY4IMjE0Af/lp+0jO320
> CjYAoOwzdswHOYjpJjG0kIISCdU1fHBm
> =7wcX
> -----END PGP SIGNATURE-----
>
>    


-- 
Regards,
Cordialement,
Emmanuel L├ęcharny
www.nextury.com



Mime
View raw message