directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Felix Knecht <fel...@apache.org>
Subject Re: Checkstyle report
Date Thu, 27 May 2010 10:29:44 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/27/10 09:53, Emmanuel Lecharny wrote:
> Hi !
> 
> looking at shared checkstyle report this morning, I'm afraid that we
> need to tune the configuration. shared-ldap contains more than 84000
> violations, most of them being about { and } position and trailing spaces.
> 
> We can get rid of those useless warnings by tuning our checkstyle
> config, using our own configuration, assuming we are not following Sun's
> rules. I saw that there are existing config files available here :
> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/?pathrev=657536
> 
> 
> It would be interesting to have our own parameters for the following
> elements :
> ParenPad (38765 errors)
> RegexpSingleline (12689 errors) (this is about trailing spaces)
> LeftCurly (9104 errors)
> LineLength (6489 errors) -> set it to 128
> MagicNumber (3512 errors) -> remove simple numbers like 1, 2 etc
> FinalParameters (2746 errors)
> DesignForExtension (2134 errors)
> RightCurly (1388 errors)
> 
> Doing so, we will have 6360 errors remaining, out of which half are
> Javadoc errors.
> thoughts ?

+1

But we should try to have a checkstyle definition either following the
coding standards [1] or adapt the coding standards to the checkstyle
definition we use.
I can remember the maven 1.x jalopy-plugin [2] which was able to format
the code following the given conventions. Maybe equal functionality
exists for checkstyle as well?

Felix

[1] https://cwiki.apache.org/DIRxDEV/coding-standards.html
[2] http://maven.apache.org/maven-1.x/plugins/jalopy/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkv+SZgACgkQ2lZVCB08qHFGUQCeNB9xumh+WFcYIrDg4ARQ08JG
NYQAn0KSFVjstImRHa7P5/SNEKzy9eUU
=jplR
-----END PGP SIGNATURE-----

Mime
View raw message