directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Lecharny <elecha...@gmail.com>
Subject Re: Merging XDBM modules
Date Wed, 19 May 2010 00:02:08 GMT
On 5/19/10 1:40 AM, Stefan Seelmann wrote:
> Emmanuel Lecharny wrote:
>    
>> On 5/17/10 11:07 PM, Stefan Seelmann wrote:
>>      
>>> Hi dev,
>>>
>>> we have a very deep dependency hierarchy within apacheds:
>>>
>>> jdbm-partition            has dependency to
>>> |- xdbm-search            has dependency to
>>>      |- jdbm-store          has test dependency to
>>>         |- core-avl         has dependency to
>>>            |- xdbm-base     has dependency to
>>>               |- core-api   has dependency to
>>>
>>> As far as I know xdbm has been spitted into two separate modules to
>>> decouple it from jdbm but keep the search engine (xdbm-search) testable
>>> using jdbm-store, which is an implementation of xdbm-base.
>>>
>>> Today we have another store implementation, the in-memory AVL store.
>>> This would make it possible to merge xdbm-base and xdbm-search again. A
>>> requirement is to move the AVL store classes from avl-partition to xdbm
>>> and use the AVL store for testing the XDBM search engine.
>>>
>>> The resulting dependency tree then would look like this:
>>>
>>> jdbm-partition
>>> |- jdbm-store
>>>      |- xdbm (merged xdbm-search and xdbm-base plus AVL store classes)
>>>         |- core-avl
>>>         |- core-api
>>>
>>> IMO this step brings lot of advantages: Less modules. Less dependencies.
>>> XDBM gets completely decoupled from JDBM.
>>>
>>> Thoughts?
>>>
>>>        
>> +1
>>
>> However, as it may break a lot of things can you do this big change in a
>> branch, then merge it ?
>>      
> Done in the branch:
> http://svn.apache.org/viewvc?rev=945891&view=rev
> http://svn.apache.org/viewvc?rev=945933&view=rev
> http://svn.apache.org/viewvc?rev=945954&view=rev
> http://svn.apache.org/viewvc?rev=945961&view=rev
>
> If there in no objection I'll merge the branch tomorrow to trunk.
>    
Go for it.--

Regards,
Cordialement,
Emmanuel L├ęcharny
www.nextury.com



Mime
View raw message