directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Felix Knecht <fe...@otego.com>
Subject Constants static but not final
Date Mon, 17 May 2010 08:43:45 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

There a multiple findings (findbugs) about static variables not being
final, e.g. [1]:
"MS: Field isn't final but should be (MS_SHOULD_BE_FINAL)
A mutable static field could be changed by malicious code or by accident
from another package. The field could be made final to avoid this
vulnerability."

I suggest setting such constants final as well.
Are there any objections?

Felix

[1]
http://people.apache.org/~felixk/shared-docs/xref/org/apache/directory/shared/dsmlv2/Tag.html#47
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkvxAcEACgkQ2lZVCB08qHGKfQCffU2ElmRWXHYJSiVilOzEsJzV
bHoAnRiRnylui3x0c/ALXnWZLJyR1auu
=bOAE
-----END PGP SIGNATURE-----

Mime
View raw message