directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Lecharny <elecha...@gmail.com>
Subject Re: svn commit: r944590 - in /directory/apacheds/trunk: core-api/src/main/java/org/apache/directory/server/core/interceptor/ core/src/main/java/org/apache/directory/server/core/ core/src/main/java/org/apache/directory/server/core/changelog/ core/src/main/j...
Date Sat, 15 May 2010 08:36:26 GMT
On 5/15/10 10:06 AM, felixk@apache.org wrote:
> Author: felixk
> Date: Sat May 15 08:06:07 2010
> New Revision: 944590
>
> URL: http://svn.apache.org/viewvc?rev=944590&view=rev
> Log:
> > From PMD report "Avoid empty catch blocks"
>    

I would not add a @SuppressWarning for such a warning. It's not good to 
have an empty catch block, and we should at least add a comment (// 
expected) if it's really expected, or add some real log if not.

I don't think that an empty catch block is a good thing (except in tests)


-- 
Regards,
Cordialement,
Emmanuel L├ęcharny
www.nextury.com



Mime
View raw message