directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Seelmann <seelm...@apache.org>
Subject Re: Is this Exception catch really wanted?
Date Sat, 15 May 2010 08:15:55 GMT
Let's add a comment into each empty catch block to describe why the
exception is catched and not handled so another developer can see the
reason.

Kiran Ayyagari wrote:
> hi Felix,
> 
>> In LdapCoreSessionConnection.java we have multiple constructs like (see
>> below). The methods declares tho throw 2 Exceptions, but with this
>> construct they are never thrown. Is this on purpose?
> yeah, cause in this implementation of LdapConnection interface there
> is no network layer
> involved and the throws clause is just there to adhere to the
> interface signatures
> 
> can fill the catch block with a log statement if required to avoid
> false positives in the reports
> 
> Kiran Ayyagari


Mime
View raw message