directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Lecharny (JIRA)" <>
Subject [jira] Commented: (DIRSHARED-27) need equals function that ignores order and oids
Date Wed, 26 May 2010 07:46:34 GMT


Emmanuel Lecharny commented on DIRSHARED-27:

Hi Steve,

I have looked at the patch, and as you have noted, I didn't closed the issue.

I was not clear in my previous comment (may be it was too late ;) : I think we will focus
on releasing a 2.0 right now, and fix this later.

What comes to my mind regarding the complexity is that when having such filters :
is that in order to compare it with 
it will requires that we order all the AND elements, and compare them one by one. 

We don't have a way to order those guys, so it ends by doing a brutal comparison with every
member of the AND filter with any of those in the second filter, which is pretty much ugly.

There are also other use cases where we might want to reorganize the filter in order to be
able to compare them, like when combining AND, OR and NOT operators.

We need to define the whole algorithm at this point, which covers all the cases, then we can
start thinking about implementing it.

> need equals function that ignores order and oids
> ------------------------------------------------
>                 Key: DIRSHARED-27
>                 URL:
>             Project: Directory Shared
>          Issue Type: New Feature
>    Affects Versions: 0.9.13
>            Reporter: Steve hammond
>            Assignee: Emmanuel Lecharny
>             Fix For: 1.1.0
>         Attachments: equalsIgnoreOrder.patch
> it would be nice to compare 2 filters without worrying about case
> also without worrying about whether one is normailized to oid's and one is not.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message