directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Lecharny (JIRA)" <>
Subject [jira] Resolved: (DIRSERVER-1059) Interceptor bypass logic is flawed
Date Mon, 31 May 2010 23:43:39 GMT


Emmanuel Lecharny resolved DIRSERVER-1059.

    Resolution: Won't Fix

It may be flawed, but currently, it's working pretty well. 

The fact that I don't like the way it's done is not a justification for a redesign of this

> Interceptor bypass logic is flawed
> ----------------------------------
>                 Key: DIRSERVER-1059
>                 URL:
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.5.1
>            Reporter: Emmanuel Lecharny
>             Fix For: 2.0.0-RC1
> We currently have many places in the code where we are hard-coding the bypassed interceptor
(ie, the interceptors which won't be called).
> I think this logic is flawed : as we can add new interceptors, those newly interceptors
will be called, or the code where those bypasses are declared should be modified.
> Reverting the logic won't help : if we create a list of called interceptors instead of
a list of bypassed interceptors, then we will still have to modify the code to add those new
interceptors in the chain.
> Some other way to handle interceptors should be find to allow users to add new interceptors
without any problem.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message