directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pierre-Arnaud Marcelot (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DIRSTUDIO-447) Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
Date Wed, 21 Apr 2010 12:05:50 GMT

    [ https://issues.apache.org/jira/browse/DIRSTUDIO-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859311#action_12859311
] 

Pierre-Arnaud Marcelot commented on DIRSTUDIO-447:
--------------------------------------------------

Hi Keheliya,

A few comments on your patch.

The fix on the SearchView is working good. :)

However, the fix on the other ATs or OCs selection dialogs is not working as we would expect
the dialog to behave.
Everything works fine when using ? and * symbol, but we expect the list to remove item while
typing and thus 'implicity' put a ".*" search pattern at the end of the regex.

Here's an example:
If I want to find the object class name "automount", I will start by typing the character
'a'.
This expected behavior of the dialog is to display in the list all object classes starting
with the character 'a' (even if I did ended my search with a '*').
Then I'll type the character 'u', which will narrow down the list to only two elements "automount"
and "automountMap".

This is more ergonomic in the way that you're narrowing the list as long as you type and once
you see the element you're interested in, you simply press the down key to select it.
This is exactly what is done in Eclipse in the Class/Interface selection dialog and it's good
to maintain the same concept in Studio for the user.

I'm sure you weren't aware of this requirement at the time you wrote the patch.

One more comment.
At Directory, we are using specific rules for code formatting and your patch does not follow
them.
Especially, we replace every tab by 4 spaces in your case.
I encourage you to load our code templates and code formatting files in your own Eclipse.
These files are located here:
http://svn.apache.org/repos/asf/directory/project/trunk/resources/codetemplates.xml
http://svn.apache.org/repos/asf/directory/project/trunk/resources/formatting.xml

One last thing.
When you have multiple strings on the same line, strings that don't need to be translated
and extracted in properties files, you should add as many "//$NON-NLS-X$" elements as strings
you have.
For example, instead of this:
    searchRegexp = searchText.replaceAll( "\\*", "[\\\\S]*" ); //$NON-NLS-1$ 
you should have that:
    searchRegexp = searchText.replaceAll( "\\*", "[\\\\S]*" ); //$NON-NLS-1$ //$NON-NLS-2$


Thanks

> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the
search
> ---------------------------------------------------------------------------------------------
>
>                 Key: DIRSTUDIO-447
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-447
>             Project: Directory Studio
>          Issue Type: Improvement
>          Components: studio-schemaeditor
>            Reporter: Pierre-Arnaud Marcelot
>            Assignee: Pierre-Arnaud Marcelot
>         Attachments: DIRSTUDIO-447-mod.patch, DIRSTUDIO-447.patch
>
>
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the
search

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message