Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 60068 invoked from network); 25 Mar 2010 15:25:45 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 25 Mar 2010 15:25:45 -0000 Received: (qmail 32069 invoked by uid 500); 25 Mar 2010 15:25:45 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 32030 invoked by uid 500); 25 Mar 2010 15:25:45 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 32023 invoked by uid 99); 25 Mar 2010 15:25:45 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Mar 2010 15:25:45 +0000 X-ASF-Spam-Status: No, hits=-0.4 required=10.0 tests=AWL,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: apache.org Received-SPF: softfail (athena.apache.org: transitioning domain of list@toolazydogs.com does not designate 209.85.220.216 as permitted sender) Received: from [209.85.220.216] (HELO mail-fx0-f216.google.com) (209.85.220.216) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Mar 2010 15:25:37 +0000 Received: by fxm8 with SMTP id 8so4271082fxm.25 for ; Thu, 25 Mar 2010 08:25:15 -0700 (PDT) Received: by 10.87.62.1 with SMTP id p1mr2143343fgk.42.1269530715028; Thu, 25 Mar 2010 08:25:15 -0700 (PDT) Received: from [192.168.1.150] (dagmar.corp.linkedin.com [69.28.149.29]) by mx.google.com with ESMTPS id 26sm2209707fks.52.2010.03.25.08.25.12 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 25 Mar 2010 08:25:13 -0700 (PDT) Message-Id: <85A6244A-9460-400C-8E70-0392CAAD19B5@toolazydogs.com> From: "Alan D. Cabrera" To: "Apache Directory Developers List" In-Reply-To: <4BAB6EFD.9090906@gmail.com> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Subject: Re: About I18n Date: Thu, 25 Mar 2010 08:25:09 -0700 References: <4BA0BC09.5070600@gmail.com> <72C4C928-B137-46C4-A335-40C15CEC6EB9@toolazydogs.com> <689D5BB2-994E-40CD-A85F-C23B77179762@gmail.com> <4BAB6EFD.9090906@gmail.com> X-Mailer: Apple Mail (2.936) On Mar 25, 2010, at 7:11 AM, Emmanuel Lecharny wrote: > On 3/25/10 8:03 AM, Alex Karasulu wrote: >> Wow u just described fully and emaculated why this proposal was >> rubbing me the wrong way. I did not have the time to run through a >> use case to see clearly - thanks for doing this and commenting for >> all our benefit. >> >> No general mechanical procedure makes up for act thought for each >> case. We have to watch for that here. >> >> I agree with Alan on this one. Let's not further obfuscate our >> code. BTW it's time for a thorough audit of error messages and log >> output since these days many are complaining about false error and >> excessive verbosity without clear meaning. > I agree with Alan. However, I don't blame Felix for having chose > this solution : he had some very good reason to do so : > - having no knowledge about the context, he wasn't able to pick a > correct name for each error > - this was a very painful task, and he did it. It's now our turn to > complete the job Yeah, I saw that. Great work! > So yes, we should move to Enum, pick correct names for those enum. > > This can be done step by step, I don't believe we could spend one > full week in a row doing that. > > I remember years ago when we had thousands of string constants all > over the code, and decided that we should gather all those constants > in a few places : it's not completely done, but it took months to do > it. Definitely a good idea. Regards, Alan