directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Felix Knecht <fe...@otego.com>
Subject Exception logging inconsistent ?
Date Wed, 03 Mar 2010 09:12:44 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all

I came across following log/exception [1]:

<snip>
String msg = "RuleId " + ruleId + " not found in ruleId to schema name
map!";
LOG.warn( msg );
throw new NamingException( msg );
</snip>

Wouldn't it be more consistent when logging an error instead of a
warning when afterwards an exception is thrown?

If wanted I can fix when I come across such codings.

Felix

[1]
shared-ldap/src/main/java/org/apache/directory/shared/ldap/schema/registries/DefaultDITStructureRuleRegistry.java
[line 103 ff]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkuOKAwACgkQ2lZVCB08qHHlVwCdE0+3OcgpNg+bSQKv68BZpUGI
vq0AnieJlkYvLJfKs1oy1fJ7fB7FFOBm
=v+UR
-----END PGP SIGNATURE-----

Mime
View raw message