Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 61799 invoked from network); 10 Dec 2009 09:37:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 10 Dec 2009 09:37:41 -0000 Received: (qmail 4391 invoked by uid 500); 10 Dec 2009 09:37:41 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 4303 invoked by uid 500); 10 Dec 2009 09:37:41 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 4293 invoked by uid 99); 10 Dec 2009 09:37:41 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Dec 2009 09:37:41 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Dec 2009 09:37:39 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 12987234C04C for ; Thu, 10 Dec 2009 01:37:18 -0800 (PST) Message-ID: <57011321.1260437838061.JavaMail.jira@brutus> Date: Thu, 10 Dec 2009 09:37:18 +0000 (UTC) From: "Emmanuel Lecharny (JIRA)" To: dev@directory.apache.org Subject: [jira] Commented: (DIRSERVER-1434) Create tests for addition of N/C/SC in SchemaManager In-Reply-To: <547645173.1260187638268.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DIRSERVER-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788624#action_12788624 ] Emmanuel Lecharny commented on DIRSERVER-1434: ---------------------------------------------- There is a slight problem in the current impl, and it should be tested : when adding a LoadableSchemaObject, the FQCN must be updated after the addition. We inject an instance of SO here, so the FQCN and the byteCode are not necessarily present, this is the reason why they should be updated. OTOH, I'm not sure if we should update the byteCode field... One more test we should do is to check that the FQCN is equal to the instance of LoadableSchemaObject. Right now, this is not done. > Create tests for addition of N/C/SC in SchemaManager > ---------------------------------------------------- > > Key: DIRSERVER-1434 > URL: https://issues.apache.org/jira/browse/DIRSERVER-1434 > Project: Directory ApacheDS > Issue Type: Test > Affects Versions: 2.0.0-RC1 > Reporter: Emmanuel Lecharny > Fix For: 2.0.0-RC1 > > > We need to add tests for C/N/SC addition : > - addition of a brand new SO > - addition of a new SO with an existing OID : should get an error > - addition of a new SO with an existing class name : should get an error > - addition of a new SO with an existing name : should get an error -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.