Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Received-SPF: pass (athena.apache.org: domain of elecharny@gmail.com
 designates 209.85.219.225 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:content-type:content-transfer-encoding;
        b=HIO5INNoqtSpDu05belejhsKkQxVLlTa2mP6wmFylflL++4qrOlNSGTbmaQ728BtKv
         3WYvbbJbKb9QU2DuD9WVEwTErf9SQZN1xFFcal4l8+fj4784+IvyksKFUiRvIvb75PSV
         VTPEYeflJHN++bobLnTWMLHbGhYSluORcRFeY=
Message-ID: <4B2A851B.4010602@gmail.com>
Date: Thu, 17 Dec 2009 20:23:07 +0100
From: =?UTF-8?B?RW1tYW51ZWwgTMKOY2hhcm55?= <elecharny@gmail.com>
User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812)
MIME-Version: 1.0
To: Apache Directory Developers List <dev@directory.apache.org>
Subject: Re: svn commit: r891807 - in
 /directory/shared/branches/shared-schema/ldap/src:
 main/java/org/apache/directory/shared/ldap/name/Rdn.java
 test/java/org/apache/directory/shared/ldap/name/RdnTest.java
References: <20091217172915.5D49B2388ABB@eris.apache.org>
 <4B2A8266.5020201@apache.org>
In-Reply-To: <4B2A8266.5020201@apache.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Stefan Seelmann a écrit :
> Hi,
>> +    @Test
>> +    public void testRDNCreation() throws InvalidNameException
>> +    {
>> +        Rdn rdn = new Rdn( "A", "  b  " );
>> +        assertEquals( "a=\\  b \\ ", rdn.getNormName() );
>> +        assertEquals( "A=  b  ", rdn.getUpName() );
>> +    }
>>   
> IMO this test is wrong. The UpName should be "A=\\ b \\ ". Leading and 
> trailing spaces in the AttributeValue must be escaped when converting 
> it to a String, see RFC 4514 Section 2.4.

Sadly, this test is not wrong :/ It's the RDN rendering of UP values 
which is wrong ... As soon as we fix it, then the test will be wrong, I 
agree :)

>