directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Lecharny (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DIRSERVER-1395) '=' is being escaped properly in RDN values
Date Thu, 06 Aug 2009 11:48:14 GMT

    [ https://issues.apache.org/jira/browse/DIRSERVER-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740003#action_12740003
] 

Emmanuel Lecharny commented on DIRSERVER-1395:
----------------------------------------------

RFC 4514 states clearly the the '=' should *not* be escaped :

distinguishedName = [ relativeDistinguishedName *( COMMA relativeDistinguishedName ) ]
relativeDistinguishedName = attributeTypeAndValue *( PLUS attributeTypeAndValue )
attributeTypeAndValue = attributeType EQUALS attributeValue
attributeValue = string / hexstring

; The following characters are to be escaped when they appear
; in the value to be encoded: ESC, one of <escaped>, leading
; SHARP or SPACE, trailing SPACE, and NULL.
string =   [ ( leadchar / pair ) [ *( stringchar / pair ) ( trailchar / pair ) ] ]

leadchar = LUTF1 / UTFMB
LUTF1 = %x01-1F / %x21 / %x24-2A / %x2D-3A / %x3D / %x3F-5B / %x5D-7F ;; The ' ', '"', '#',
'+', ',', ';', '<', '>' and '\' are not part of this list

trailchar  = TUTF1 / UTFMB
TUTF1 = %x01-1F / %x21 / %x23-2A / %x2D-3A / %x3D / %x3F-5B / %x5D-7F ;; The ' ', '"', '#',
'+', ',', ';', '<', '>' and '\' are not part of this list

stringchar = SUTF1 / UTFMB
SUTF1 = %x01-21 / %x23-2A / %x2D-3A / %x3D / %x3F-5B / %x5D-7F ;; The '"', '+', ',', ';',
'<', '>' and '\' are not part of this list
pair = ESC ( ESC / special / hexpair )
special = escaped / SPACE / SHARP / EQUALS
escaped = DQUOTE / PLUS / COMMA / SEMI / LANGLE / RANGLE ;; The escaped chars are '"', ',',
';', '<' and '>'
hexstring = SHARP 1*hexpair
hexpair = HEX HEX


> '=' is being escaped properly in RDN values
> -------------------------------------------
>
>                 Key: DIRSERVER-1395
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1395
>             Project: Directory ApacheDS
>          Issue Type: Bug
>          Components: ldap
>    Affects Versions: 1.5.4, 1.0
>         Environment: Windows XP
>            Reporter: Norval Hope
>         Attachments: rdn_value_with_equal.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> A colleague of mine discovered that due to a mistake in a boolean array (AttributeTypeAndValue.DN_ESCAPED_CHARS)
the '=' character is not escaped during RDN normalization when it appears in a RDN value.
This may be due to http://www.faqs.org/rfcs/rfc2253.html seemingly leaving it in "2.4.  Converting
an AttributeValue from ASN.1 to a String" but then including it in the "special  = " BNF clause.
> The attached patch fixes the problem, adds a new testcase covering it and fixes a few
other testcases which tested for the old (broken) behaviour.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message