Return-Path: 
 <dev-return-30586-apmail-directory-dev-archive=directory.apache.org@directory.apache.org>
Delivered-To: apmail-directory-dev-archive@www.apache.org
Received: (qmail 14372 invoked from network); 13 Jun 2009 09:41:52 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 13 Jun 2009 09:41:52 -0000
Received: (qmail 93437 invoked by uid 500); 13 Jun 2009 09:42:03 -0000
Delivered-To: apmail-directory-dev-archive@directory.apache.org
Received: (qmail 93350 invoked by uid 500); 13 Jun 2009 09:42:03 -0000
Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@directory.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@directory.apache.org>
List-Post: <mailto:dev@directory.apache.org>
List-Id: <dev.directory.apache.org>
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Delivered-To: mailing list dev@directory.apache.org
Received: (qmail 93342 invoked by uid 99); 13 Jun 2009 09:42:03 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 13 Jun 2009 09:42:03 +0000
X-ASF-Spam-Status: No, hits=4.6 required=10.0
	tests=FH_HELO_EQ_D_D_D_D,HELO_DYNAMIC_IPADDR,SPF_NEUTRAL
X-Spam-Check-By: apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Received: from [92.51.130.250] (HELO
 lvps92-51-130-250.dedicated.hosteurope.de) (92.51.130.250)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 13 Jun 2009 09:41:55 +0000
Received: from [127.0.0.1] (localhost [127.0.0.1])
	by lvps92-51-130-250.dedicated.hosteurope.de (Postfix) with ESMTP id
 EA0581174400A
	for <dev@directory.apache.org>; Sat, 13 Jun 2009 09:41:33 +0000 (UTC)
Message-ID: <4A33744D.6040703@apache.org>
Date: Sat, 13 Jun 2009 11:41:33 +0200
From: Stefan Seelmann <seelmann@apache.org>
User-Agent: Thunderbird 2.0.0.21 (X11/20090409)
MIME-Version: 1.0
To: Apache Directory Developers List <dev@directory.apache.org>
Subject: Re: Questionning some parts of the configuration, proposal
References: <4A313A6D.3010100@nextury.com> <4A313F75.6090609@nextury.com>
 <4A333F88.8050207@nextury.com>
In-Reply-To: <4A333F88.8050207@nextury.com>
X-Enigmail-Version: 0.95.7
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org

> 3) LdapService
> This class is now used only once in the ApacheDS class, as we don't need
> to define one instance to manage LDAP and another one for LDAPS : both
> are managed through a different transport. As a consequence, a flag is
> removed (enableSSL) : this flag depends on the SSL enabled transport
> presence.
> The getPort() method has been completed with a getportSSL() which
> returns the LDAPS associated transport port. The getPort() now returns
> the port for the non SSL transport.
Would be good to rename it to _LdapServer_, just to be consistent to the
naming of the other servers.

> 4) ApacheDS
> This class encapsulated the LdapServer and all the other servers. As a
> direct consequence of the transports modifcations, I have move dmost of
> the specific configuration up to the LdapService. The second impact is
> that we don't need to instanciate twice the LdapService (one for LDAP
> and anotherone for LDAPS), plus the reference to DirectoryService is now
> useless, as it's already present in the unique LdapService instance.
Emmanuel and I just discussed on IRC, it should be possible to get rid
of the ApacheDS class because it just grouped the LdapServices.

> o The LdapService bean has also been slighly modified, so that it can
LdapServer?

>  <dnsServer>
>    <tcpTransports>
>      <tcpTransport port="8053"/>
>    </tcpTransports>
>    <udpTransports>
>      <udpTransport port="8053"/>
>    </udpTransports>
>    <directoryService>#directoryService</directoryService>
>  </dnsServer>

This transports configuration looks a bit chatty. A simpler solution
could be:

<...Server>
  <transports>
    <tcpTransport .../>
    <udpTransport .../>
  </transports>
</...Server>

Or

<...Server>
  <tcpTransport .../>
  <udpTransport .../>
</...Server>

Kind Regards,
Stefan