From dev-return-30554-apmail-directory-dev-archive=directory.apache.org@directory.apache.org Sun Jun 07 16:13:59 2009 Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 93615 invoked from network); 7 Jun 2009 16:13:59 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 7 Jun 2009 16:13:59 -0000 Received: (qmail 16914 invoked by uid 500); 7 Jun 2009 16:14:10 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 16835 invoked by uid 500); 7 Jun 2009 16:14:10 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 16826 invoked by uid 99); 7 Jun 2009 16:14:10 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Jun 2009 16:14:10 +0000 X-ASF-Spam-Status: No, hits=4.6 required=10.0 tests=FH_HELO_EQ_D_D_D_D,HELO_DYNAMIC_IPADDR,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [92.51.130.250] (HELO lvps92-51-130-250.dedicated.hosteurope.de) (92.51.130.250) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Jun 2009 16:14:01 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lvps92-51-130-250.dedicated.hosteurope.de (Postfix) with ESMTP id 148721174400A for ; Sun, 7 Jun 2009 16:13:41 +0000 (UTC) Message-ID: <4A2BE733.2060103@apache.org> Date: Sun, 07 Jun 2009 18:13:39 +0200 From: Stefan Seelmann User-Agent: Thunderbird 2.0.0.21 (X11/20090409) MIME-Version: 1.0 To: Apache Directory Developers List Subject: Re: [Client API] ModifyDN and Delete operations References: <4A2B72B6.7080901@gmail.com> <4A2BD9DF.6080100@gmail.com> In-Reply-To: <4A2BD9DF.6080100@gmail.com> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Hi, > > > Emmanuel Lecharny wrote: >>> * modifyDn( String entryDn, String newRdn, boolean deleteOldRdn ) >>> * modifyDn( String entryDn, String newRdn, String newParentDn, >>> boolean >>> deleteOldRdn ) >>> * modifyDn( LdapDN entryDn, Rdn newRDN, boolean deleteOldRDN ) >>> * modifyDn( LdapDN entry, Rdn newRDN, LdapDN newParentDn, boolean >>> deleteOldRDN ) >>> * modifyDn( ModifyDNRequest modDnRequest, ModifyDnListener listener ) >> >> Sounds good. I'm wondering if offering methods like : >> rename( LdapDN oldDN, RDN newRdn) >> move( LdapDN oldDN, LdapDN newDn) >> >> would be better or not ? > same here, and finally thought of going with the 'modifyDn' name as per > RFC but > really prefer the move and rename methods. > what do you say again, should we go for these names? from my side +1. > Want to hear from others too, who might have used different client > libraries. +1 > >> >> Also, I think it's probably better to have the same method without the >> deleteOldRdn flag (it's not really frequently used, and it can default >> to true). Yes, a overload without this flag would be good. >> >> Last, not least, accepting String could be cool, but we can extend the >> API later. > yeah, the list of overloaded methods for this operation is higher than > any other > operation. >>> Delete operation: >>> >>> * delete( String dn ) >>> * delete( LdapDN dn ) >>> * delete( DeleteRequest delRequest, DeleteListener listener ) >> >> Loks fine to me. >> >> What about another method to allow deletion of children ? >> >> deleteChildren( String/LdapDN dn) ? What would be the exact meaning of this method? - only the immediate children - recursively all children - the DN plus recursively all children But what would be tricky is the implementation: - Use tree delete control - try to delete parent first, if error delete children first - check for children first - what about following aliases and referrals, could be Kind Regards, Stefan