directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Lecharny (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (DIRSHARED-25) BranchNormalizedVisitor cannot handle Nots
Date Sat, 06 Jun 2009 10:12:07 GMT

     [ https://issues.apache.org/jira/browse/DIRSHARED-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Emmanuel Lecharny resolved DIRSHARED-25.
----------------------------------------

    Resolution: Fixed

Patch applied in http://svn.apache.org/viewvc?view=rev&revision=746607 (4 months ago...)

Thanks Steve !

> BranchNormalizedVisitor cannot handle Nots
> ------------------------------------------
>
>                 Key: DIRSHARED-25
>                 URL: https://issues.apache.org/jira/browse/DIRSHARED-25
>             Project: Directory Shared
>          Issue Type: Bug
>    Affects Versions: 0.9.11
>            Reporter: Steve hammond
>            Assignee: Emmanuel Lecharny
>             Fix For: 0.9.14
>
>         Attachments: BranchNorm.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> SearchRequestImpl uses BranchNormalizedVisitor and fails on comparisons if there is a
not in the clause.
> To fix it I removed the (if NotNode) return null.  And all was well.
> I tried to add the following test to BranchNormalizedVisitorTest
>    public void testBranchNormalizedVisitor4() throws Exception
>    {
>        ExprNode ori = FilterParser.parse( "(&(!(sn=Bob))(ou=Human Resources)(uid=akarasulu))"
);
>        ExprNode altered = FilterParser.parse( "(&(ou=Human Resources)(uid=akarasulu)(!(sn=Bob)))"
);
>        BranchNormalizedVisitor visitor = new BranchNormalizedVisitor();
>        visitor.visit( altered );
>        assertTrue( ori.toString().equals( altered.toString() ) );
>        
>    }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message