Hi Emmanuel,
Actually we're not using those sysouts to update the states of the server.
We're checking the ports to verify if a server is stopped/starting/started.
So, it can be removed without issue.
Regards,
Pierre-Arnaud
On Fri, Apr 10, 2009 at 12:51 AM, Emmanuel Lecharny <elecharny@apache.org>wrote:
> On Thu, Apr 9, 2009 at 7:22 PM, Alex Karasulu <akarasulu@gmail.com> wrote:
> >
> > On Thu, Apr 9, 2009 at 1:11 PM, Martin Alderson
> > <Martin.Alderson@salfordsoftware.co.uk> wrote:
> >>
> >> > Martin these are not Log messages but purely System.out.println()
> method
> >> > calls.
> >> >
> >> > Alex
> >>
> >> Looks like there's both:
> >>
> >> LOG.info( "Ldap service started." );
> >> System.out.println( "Ldap service started." );
> >>
> >> I think it could be useful to have ServiceListeners anyway, but for this
> >> case I would have thought the usual logging configuration would be
> enough
> >> (after the System.out.printlns have been removed).
> >>
> >
> > Oh yes u are right. I was not even thinking about the log statements
> which
> > can be filtered via the log4j.configuration.
>
> No that's not enough. Those info are used by studio to update the
> Server states. Using the logs is too complicated. If we don't want to
> implement the listeners, then we should keep those System.out.
>
>
>
> --
> Regards,
> Cordialement,
> Emmanuel Lécharny
> www.iktek.com
>
|