Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Message-ID: <507075252.1234995001870.JavaMail.jira@brutus>
Date: Wed, 18 Feb 2009 14:10:01 -0800 (PST)
From: "Steve hammond (JIRA)" <jira@apache.org>
To: dev@directory.apache.org
Subject: [jira] Updated: (DIRSHARED-25) BranchNormalizedVisitor cannot
 handle Nots
In-Reply-To: <1525153081.1234980361893.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/DIRSHARED-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve hammond updated DIRSHARED-25:
-----------------------------------

    Attachment: BranchNorm.patch

> BranchNormalizedVisitor cannot handle Nots
> ------------------------------------------
>
>                 Key: DIRSHARED-25
>                 URL: https://issues.apache.org/jira/browse/DIRSHARED-25
>             Project: Directory Shared
>          Issue Type: Bug
>    Affects Versions: 0.9.11
>            Reporter: Steve hammond
>         Attachments: BranchNorm.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> SearchRequestImpl uses BranchNormalizedVisitor and fails on comparisons if there is a not in the clause.
> To fix it I removed the (if NotNode) return null.  And all was well.
> I tried to add the following test to BranchNormalizedVisitorTest
>    public void testBranchNormalizedVisitor4() throws Exception
>    {
>        ExprNode ori = FilterParser.parse( "(&(!(sn=Bob))(ou=Human Resources)(uid=akarasulu))" );
>        ExprNode altered = FilterParser.parse( "(&(ou=Human Resources)(uid=akarasulu)(!(sn=Bob)))" );
>        BranchNormalizedVisitor visitor = new BranchNormalizedVisitor();
>        visitor.visit( altered );
>        assertTrue( ori.toString().equals( altered.toString() ) );
>        
>    }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.