From dev-return-28993-apmail-directory-dev-archive=directory.apache.org@directory.apache.org Wed Feb 18 10:56:13 2009 Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 92905 invoked from network); 18 Feb 2009 10:56:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 18 Feb 2009 10:56:13 -0000 Received: (qmail 73288 invoked by uid 500); 18 Feb 2009 10:56:12 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 73253 invoked by uid 500); 18 Feb 2009 10:56:12 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 73244 invoked by uid 99); 18 Feb 2009 10:56:12 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Feb 2009 02:56:12 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of elecharny@gmail.com designates 209.85.198.239 as permitted sender) Received: from [209.85.198.239] (HELO rv-out-0506.google.com) (209.85.198.239) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Feb 2009 10:56:04 +0000 Received: by rv-out-0506.google.com with SMTP id l9so2689833rvb.25 for ; Wed, 18 Feb 2009 02:55:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to :content-type:content-transfer-encoding; bh=3li8/gyHFR6eoOwzp+ddzw6pn3d2/4dwgtxB3MIu/ik=; b=VNnR7I7br3PPfe++b6oAgYHV7/VUsGnrWtY7WOMJ229YFPHG+W+Gvl/o6ipbFi5h8t z981w4vxSm/lyrBpPRX64VHBzfkfh9oEI0qdKS2ezcCk1hrGz1lN9oU91cZjXMMb6aW1 yekOwgcs03BzSPot4aABH2ohM/Sd79fD7lZqc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; b=GShvQbTeKSeRlt6TfBiK/MVwOqEARFU3QApxcF1wN772HzABxoUTM43MgNOkr2yb/8 oPjU/WxoJ6chOuUrWNqa6IcVJNOd5edskII1CAwDb5dqNfWJDhrrvlQ2eiNASfw/EQOd FNvvqkBvUXChLIIiMMJ53FexWQGrQKosEjvqc= MIME-Version: 1.0 Sender: elecharny@gmail.com Received: by 10.142.226.10 with SMTP id y10mr3591569wfg.3.1234954542525; Wed, 18 Feb 2009 02:55:42 -0800 (PST) In-Reply-To: References: <499B2F03.8050404@nextury.com> <499B32A5.70401@nextury.com> Date: Wed, 18 Feb 2009 11:55:42 +0100 X-Google-Sender-Auth: 988be1b200b4ae60 Message-ID: Subject: Re: ChangeLog + revert, broken , take 2 From: Emmanuel Lecharny To: Apache Directory Developers List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org > The separate clear() and revert() operations decouples functionality. Th= e > revertAndClear() operations both couples functionality together. You mig= ht > find situations where you just need to clear() or just to revert() and > sometimes to do both as is the case now. When we break things down into > simpler functions that do one thing and only one thing well then it's eas= ier > to recombine them to suite different situations. This may also lead to > better interface design. Having thought about those methods a bit more, I think that clear() and revert() are different. Clear() simply remove every entry from the server _and_ from the changeLog, when revert() remove entries from the server bug logs revert operations into the changeLog. You can't do a revert() followed by a clear(), it's a waste, as everything you will write in the changeLog in the revert() method will be erased by the clear() method. So the clear() semantic is : remove everything from server and changelog up to the latest tag (or up to a specified tag) and the revert() semantic is : revert everything from the serve, but log the reverted operations in the changeLog. You can revert a revert (redo). > > Alex > > --=20 Regards, Cordialement, Emmanuel L=E9charny www.iktek.com