directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve hammond (JIRA)" <j...@apache.org>
Subject [jira] Created: (DIRSHARED-24) Filter comparison with and node does not work
Date Fri, 13 Feb 2009 22:32:59 GMT
Filter comparison with and node does not work
---------------------------------------------

                 Key: DIRSHARED-24
                 URL: https://issues.apache.org/jira/browse/DIRSHARED-24
             Project: Directory Shared
          Issue Type: Bug
    Affects Versions: 0.9.13, 0.9.12, 0.9.11
            Reporter: Steve hammond
            Priority: Critical


at the bottom of andNode.java the equals function is comparing children(i) to children(i)
and not children(i) to otherChildren(i)

        for ( int i = 0; i < children.size(); i++ )
        {
            ExprNode child = children.get( i );
            ExprNode otherChild = children.get( i );
            
            if ( !child.equals( otherChild ) )
            {
                return false;
            }
        }

Simple change needs to be 

        for ( int i = 0; i < children.size(); i++ )
        {
            ExprNode child = children.get( i );
            ExprNode otherChild = otherChildren.get( i );
            
            if ( !child.equals( otherChild ) )
            {
                return false;
            }
        }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message