directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve hammond (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DIRSHARED-27) need equals function that ignores order and oids
Date Sun, 22 Feb 2009 04:53:02 GMT

    [ https://issues.apache.org/jira/browse/DIRSHARED-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675624#action_12675624
] 

Steve hammond commented on DIRSHARED-27:
----------------------------------------

This patch may run you into troubles because of the way that you implemented the clone patch.
for example,  AndNode now returns super.clone(), which is a branch node.  So now your clone
will not equal your original, since the equals function that exists compares instanceof  and
the AndNode and BranchNode are not the same class.  (that is why I did not use super.clone()
in my patch for DIRSHARED-26)

Hopefully you know another way around it.

And don'f forget the DIRSERVER piece of this fix in the comment above.

> need equals function that ignores order and oids
> ------------------------------------------------
>
>                 Key: DIRSHARED-27
>                 URL: https://issues.apache.org/jira/browse/DIRSHARED-27
>             Project: Directory Shared
>          Issue Type: New Feature
>    Affects Versions: 0.9.13
>            Reporter: Steve hammond
>            Assignee: Emmanuel Lecharny
>         Attachments: equalsIgnoreOrder.patch
>
>
> it would be nice to compare 2 filters without worrying about case
> also without worrying about whether one is normailized to oid's and one is not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message