directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kiran Ayyagari <ayyagariki...@gmail.com>
Subject Re: [ChangeLog] Destroy() method semantic
Date Wed, 28 Jan 2009 18:05:49 GMT

AFAIU, the destroy in CL is intended for flushing the changes and closing the open resources
rather than for removing. I have implemented a custom CL's destroy() in the same way.

May be the method name is misleading.

Kiran Ayyagari

Emmanuel Lecharny wrote:
> Hi,
> 
> I'm looking at the MemoryChangeLogStore, and the destroy() method
> implementation do a full save on disk :
> 
> public void destroy() throws Exception
> {
>     saveRevision();
>     saveTags();
>     saveChangeLog();
> }
> 
> Is there any reason to do that ? Shouldn't we remove everything
> instead of saving data ?
> 
> It's not necessarily important for the memory CL, but for a disk CL,
> we have to decide what is the exact semantic of this method.
> 
> 

Mime
View raw message