directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Lecharny (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DIRSHARED-20) Modify the BooleanSyntaxChecker to accept the value TRUE/FALSE in lower case
Date Sun, 02 Nov 2008 14:44:44 GMT

    [ https://issues.apache.org/jira/browse/DIRSHARED-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644590#action_12644590
] 

Emmanuel Lecharny commented on DIRSHARED-20:
--------------------------------------------

The change is pretty simple :
- first modify the syntaxChecker to allow lowerCase values (this is about changing from 'equals'
to 'equalsIgnoreCase' at the end of this class
- second upper case the values to be sure we don't have any corner case later in the server.
This is done in the normalizationInterceptor, but that mean we have to add a BooleanNormalizer
in shared-ldap, and associate this to the Boolean OID.

All in all, it's a couple of hours, tests included.

The most important part of it is the tests, and especially in the schema area, because we
are using those Boolean values when defining new AT or OC in the schema, AFAIR.

> Modify the BooleanSyntaxChecker to accept the value TRUE/FALSE in lower case
> ----------------------------------------------------------------------------
>
>                 Key: DIRSHARED-20
>                 URL: https://issues.apache.org/jira/browse/DIRSHARED-20
>             Project: Directory Shared
>          Issue Type: Improvement
>            Reporter: Kiran Ayyagari
>            Priority: Minor
>
> Currently BooleanSyntaxChecker allows boolean value in uppercase only i.e TRUE/FALSE.
The idea is to relax this restriction a bit in way so that it accepts the value in lower or
mixed case but validates it after converting the value to upper case. 
> This helps when user directly passes a boolean value e.x Boolean.TRUE.toString() to the
ServerEntry
> Note: This issue needs to be closed only after confirming that the VSLDAP tests related
to this are passed 
>          otherwise the changes need to be rolled back.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message