Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 80558 invoked from network); 2 Oct 2008 13:47:14 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 2 Oct 2008 13:47:14 -0000 Received: (qmail 17211 invoked by uid 500); 2 Oct 2008 13:47:12 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 17182 invoked by uid 500); 2 Oct 2008 13:47:12 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 17171 invoked by uid 99); 2 Oct 2008 13:47:12 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Oct 2008 06:47:12 -0700 X-ASF-Spam-Status: No, hits=2.0 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of akarasulu@gmail.com designates 209.85.200.171 as permitted sender) Received: from [209.85.200.171] (HELO wf-out-1314.google.com) (209.85.200.171) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Oct 2008 13:46:10 +0000 Received: by wf-out-1314.google.com with SMTP id 27so1122829wfd.31 for ; Thu, 02 Oct 2008 06:46:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:in-reply-to:mime-version:content-type:references :x-google-sender-auth; bh=O1GN8g3i1kddca+VBCMs3+nxedvJh2mwyh56RSuZ+qY=; b=JuCALuEHqPRBJD1vxaJwnJoVbyGsLms8oUU709QBS9VF9LXIirXm1+dR9f208GZ9wR Y/Ln5CSSA3U0QmHGS53HkhoHbdi5+z2qtdUtP0lY6rruwBIDM0GFiayS+/vB14Dfmj4n gpSKruzaLyo7CW5JMVFSV9UPZ9lcwZMAuFLuQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:in-reply-to:mime-version :content-type:references:x-google-sender-auth; b=qWSW7byhg2LjGlvhqmk3+9mb3E+CZfWEUlLmce1lFKfA1jLT2W6pHEZ7a/Q8tb60iK la06/PhcZobjUSlZXExQgj6dgdpChB2Z/CunqC7g3wc1k75HgB9d10HstLtdVjgyN+84 yo1j4/3VVi9FF21T6/FSlLOJ4o1nGxc62Lmjs= Received: by 10.115.78.1 with SMTP id f1mr10751113wal.150.1222955195885; Thu, 02 Oct 2008 06:46:35 -0700 (PDT) Received: by 10.114.66.3 with HTTP; Thu, 2 Oct 2008 06:46:35 -0700 (PDT) Message-ID: Date: Thu, 2 Oct 2008 09:46:35 -0400 From: "Alex Karasulu" Sender: akarasulu@gmail.com To: "Apache Directory Developers List" Subject: Re: Ldap.toString() returning a Normalized DN is an error... In-Reply-To: <98d8c0860810020637g2ce0ee64r33f18571380f4120@mail.gmail.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_2707_13568950.1222955195868" References: <48E4CD79.9070401@nextury.com> <98d8c0860810020637g2ce0ee64r33f18571380f4120@mail.gmail.com> X-Google-Sender-Auth: 9362b7cca3eeb518 X-Virus-Checked: Checked by ClamAV on apache.org ------=_Part_2707_13568950.1222955195868 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline +1 Yep sounds better. I never used toString() to get the NDN; I preferred using the explicit accessor getNormName(). Alex On Thu, Oct 2, 2008 at 9:37 AM, Pierre-Arnaud Marcelot wrote: > Hi Emmanuel, > > On Thu, Oct 2, 2008 at 3:32 PM, Emmanuel Lecharny wrote: > >> Hi guys, >> >> I'm realizing that the LdapDN.toString() method returning a normalized DN >> was a truly bad idea. It's used all over the code, for instance to generate >> error messages, and this is obfuscating them. >> >> It would be way better if the toString() method returns the user provided >> DN so that the semantic of this method is kept. All in all, the toString() >> method is supposed to return something whichj is readable by human beings, >> when 1.3.6.1.4.1.18060.0.4.0.2.1=test is not :) >> >> So what about replacing the current implementation to return the UP name >> instead of the Normname ? > > > I think it makes sense. > +1 > > Regards, > Pierre-Arnaud > > ------=_Part_2707_13568950.1222955195868 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline
+1

Yep sounds better.  I never used toString() to get the NDN; I preferred using the explicit accessor getNormName().

Alex

On Thu, Oct 2, 2008 at 9:37 AM, Pierre-Arnaud Marcelot <pa@marcelot.net> wrote:
Hi Emmanuel,

On Thu, Oct 2, 2008 at 3:32 PM, Emmanuel Lecharny <elecharny@gmail.com> wrote:
Hi guys,

I'm realizing that the LdapDN.toString() method returning a normalized DN was a truly bad idea. It's used all over the code, for instance to generate error messages, and this is obfuscating them.

It would be way better if the toString() method returns the user provided DN so that the semantic of this method is kept. All in all, the toString() method is supposed to return something whichj is readable by human beings, when 1.3.6.1.4.1.18060.0.4.0.2.1=test is not :)

So what about replacing the current implementation to return the UP name instead of the Normname ?

I think it makes sense.
+1

Regards,
Pierre-Arnaud


------=_Part_2707_13568950.1222955195868--