directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Karasulu" <akaras...@apache.org>
Subject Re: [ApacheDS] [BindHandler] Ignored exception?
Date Sun, 07 Sep 2008 22:39:28 GMT
Can you add a JIRA with the background knowledge you have on this so we can
schedule it for a later release?

Thanks,
Alex

On Sun, Sep 7, 2008 at 4:28 PM, Emmanuel Lecharny <elecharny@gmail.com>wrote:

> I think it's just because some methdosz are throwing exception, so we
> have to catch them. This portion of the code is the last part of the
> SASL bidning, when the nego is completed, and we are cleaning
> everythong in the session (like the credentials) before starting.
>
> We may have to check which excpetion could be thrown, in order to
> react correctly.
>
> Sometime, a method throw an exception even when it's known that
> nothong wrong could happen, but you still have to catch the exception.
> This is certainly a sign that the design is weak...
>
> On Sun, Sep 7, 2008 at 9:25 PM, Alex Karasulu <akarasulu@apache.org>
> wrote:
> > There's an ignored exception on line 492 of BindHandler (protocol-ldap
> > module) [0] that gets swallowed up without anything.  I added a log
> message
> > but I was just wondering if there was some intent to ignore this.
> >
> > Emm can you provide some feedback on this.  Also there is some unused
> code.
> > Don't know if this is temporary though but things like getSubject() and
> > getSaslRealms() is not used.
> >
> > Alex
> >
> > -------
> > [0] - http://ahvieb.notlong.com
> >
>
>
>
> --
> Regards,
> Cordialement,
> Emmanuel L├ęcharny
> www.iktek.com
>

Mime
View raw message