directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Norval Hope (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DIRSERVER-1255) unit tests fail on windows (jdbm-store and core-integ)
Date Tue, 16 Sep 2008 11:30:47 GMT

    [ https://issues.apache.org/jira/browse/DIRSERVER-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631343#action_12631343
] 

Norval Hope commented on DIRSERVER-1255:
----------------------------------------

I'm fairly certain that the close()s are needed or the file.delete() will return false (i.e.
not delete the file). However, what I'm unfortunately 100% sure of is that it the major root
problem behind almost of all of the test failures on Windoze was in Transactionmanager.commit():

        oos = new ObjectOutputStream(fos);

which meant every commit there was another new oos wrapping the same underlying fos (and it
isn't possible to oos.close() or the underlying fos gets closed too). On Windoze this is what
stopped the file from being deleted, so I changed this to:

        oos.reset();

If it isn't possible to fix this stuff in the best place for the moment, then the only other
option that comes to mind is changing the tests so that they don't care whether deleting the
test directory succeeds or not (and leave temp dirs hanging around). I suppose maybe maven
could forcibly delete the temp dirs after the tests had run to completion (not that I'd volunteer
for trying to work out how :-) ).


> unit tests fail on windows (jdbm-store and core-integ)
> ------------------------------------------------------
>
>                 Key: DIRSERVER-1255
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1255
>             Project: Directory ApacheDS
>          Issue Type: Bug
>          Components: core, tools
>    Affects Versions: 1.5.4
>         Environment: C:\src\ad-1.5.4>mvn -version
> Maven version: 2.0.8
> Java version: 1.5.0_11
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> C:\src\ad-1.5.4>java -version
> java version "1.5.0_11"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_11-b03)
> Java HotSpot(TM) Client VM (build 1.5.0_11-b03, mixed mode, sharing)
> and running mvn from a dos command prompt 
>            Reporter: Norval Hope
>            Priority: Blocker
>         Attachments: jdbm-store-test-failures.patch, test-failures.patch
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> A checkout of http://svn.apache.org/repos/asf/directory/apacheds/trunk-with-dependencies
followed by a "mvn install" fails. Initially jdbm-store/ fails with:
> Tests in error:
>  testNoEqualityMatching(org.apache.directory.server.core.partition.impl.btree.jdbm.JdbmIndexTest)
>  testSingleValuedAttribute(org.apache.directory.server.core.partition.impl.btree.jdbm.JdbmIndexTest)
> If JdbmIndexTest is moved out of the way then there are bulk failures in core-integ/
.
> The evidence seems to indicate that all the failures are related to deletion of temp
directories failing due windows filesystem semantics.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message