directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Norval Hope (JIRA)" <>
Subject [jira] Commented: (DIRSERVER-1247) removing unrequired escaping in DNs / filters
Date Tue, 16 Sep 2008 05:29:46 GMT


Norval Hope commented on DIRSERVER-1247:

Hi All,

Was hoping one of the core team could cast their eye over this patch at some stage, and give
me some feeling whether the jist of the patch is of interest to the project (seems very probable
to me) or whether I'll just maintain it as one of my many custom mods. I have updated lots
of unit tests and added quite a few in the patch, so if some bits are interesting and others
aren't then the tests may provide a quick way to get an overview.

If there is some interest then I can spend a bit of time adjusting / culling / encorporating
feedback during my current job of porting to 1.5.4 / 5 but if there is no response in the
next week or so then I'll just close the issue and move on.


> removing unrequired escaping in DNs / filters
> ---------------------------------------------
>                 Key: DIRSERVER-1247
>                 URL:
>             Project: Directory ApacheDS
>          Issue Type: Improvement
>          Components: ldap
>    Affects Versions: 1.5.4
>            Reporter: Norval Hope
>         Attachments: escaping.patch
>   Original Estimate: 8h
>  Remaining Estimate: 8h
> The current Dn and filter handling is overly restrictive in that all non-ascii characters
are quoted using the \NN syntax. This is probably due to rfc 2253 being unclear about the
fact that multibyte UTF-8 encoded values can be used, but this iss further clarified in rfc
4514 which superceeds 2253. The application of unrequired quoting makes debugging / reading
logs much harder then it should be, as it requires manual calculations rather then just setting
the file encoding on your log file / IDE windows to being UTF-8.
> I have attached a patch file with the required updates to code and unit tests under /shared/ldap
(some problems i had noted with earlier AD version due to unspecified encoding when converting
bytes to / from Strings had already been tidied up in AD 1.5.4). 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message