directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Norval Hope (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DIRSERVER-1247) removing unrequired escaping in DNs / filters
Date Wed, 10 Sep 2008 12:16:44 GMT

    [ https://issues.apache.org/jira/browse/DIRSERVER-1247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629779#action_12629779
] 

Norval Hope commented on DIRSERVER-1247:
----------------------------------------

Note that I have more to add to this patch re filter processing, but won't do so until the
trunk is fixed to complete all the tests when run on windows. The major additions I have for
filters are:
    a) fix problem where \NN escape (e.g. "\AAAA" treated as if it was "\AA\AA") sequence
immediately followed by further hex chars were incorrectly treated as a continutation of the
escape, even though there wasn't another '\' 
    b) added checks to test that same filter string passed into parse() resulted when performed
ultimate exprNode.toString()

> removing unrequired escaping in DNs / filters
> ---------------------------------------------
>
>                 Key: DIRSERVER-1247
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1247
>             Project: Directory ApacheDS
>          Issue Type: Improvement
>          Components: ldap
>    Affects Versions: 1.5.4
>            Reporter: Norval Hope
>         Attachments: escaping.patch
>
>   Original Estimate: 8h
>  Remaining Estimate: 8h
>
> The current Dn and filter handling is overly restrictive in that all non-ascii characters
are quoted using the \NN syntax. This is probably due to rfc 2253 being unclear about the
fact that multibyte UTF-8 encoded values can be used, but this iss further clarified in rfc
4514 which superceeds 2253. The application of unrequired quoting makes debugging / reading
logs much harder then it should be, as it requires manual calculations rather then just setting
the file encoding on your log file / IDE windows to being UTF-8.
> I have attached a patch file with the required updates to code and unit tests under /shared/ldap
(some problems i had noted with earlier AD version due to unspecified encoding when converting
bytes to / from Strings had already been tidied up in AD 1.5.4). 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message