Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Received-SPF: pass (athena.apache.org: domain of akarasulu@gmail.com
 designates 74.125.46.28 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:sender:to:subject:in-reply-to:mime-version
         :content-type:references:x-google-sender-auth;
        b=Jcp9OUFBs1Ccoe5pVPmT/mfQuDNihCg1IoWIu5F8R1+kzy+Rtp4ctBrU78luzMcoTf
         AbWfAYj/22wS7qMRv1KJJMQGGadKaOdUiGyv2h5bBOic1qFEXWFtPN9YkPEESYy2EK12
         qlNTeuN8j4x8S1+EloQQZZ6o/vIrpNoWg17Bg=
Message-ID: <a32f6b020808241526l2d51f608oa10af83eb4910ba8@mail.gmail.com>
Date: Sun, 24 Aug 2008 18:26:21 -0400
From: "Alex Karasulu" <akarasulu@apache.org>
Sender: akarasulu@gmail.com
To: "Apache Directory Developers List" <dev@directory.apache.org>,
	elecharny@nextury.com
Subject: Re: [mitosis] ReplicaId
In-Reply-To: <48B1DEFB.1080301@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_61355_22026851.1219616781863"
References: <48B1DEFB.1080301@gmail.com>

------=_Part_61355_22026851.1219616781863
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On Sun, Aug 24, 2008 at 6:21 PM, Emmanuel Lecharny <elecharny@gmail.com>wrote:

> Hi guys,
>
> I had a look at the ReplicaId class today, and I have a question :
> - do we really need a class to store an Id, even if we want this ID to be
> constrained ?
>

We never needed it.  It's just crap code.


>
> I would rather store the Id as a String, and remove completely the class,
> as the constraint can be checked when reading the configuration, and that's
> it.
>

Go for it.


>
> I don't really think it's necessary to create new ReplicaId() all over the
> code, nor calling replicaId.getId() to get the String representing this Id.
> KISS principle...
>

+1

Alex

------=_Part_61355_22026851.1219616781863
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

<div dir="ltr"><br><br><div class="gmail_quote">On Sun, Aug 24, 2008 at 6:21 PM, Emmanuel Lecharny <span dir="ltr">&lt;<a href="mailto:elecharny@gmail.com">elecharny@gmail.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi guys,<br>
<br>
I had a look at the ReplicaId class today, and I have a question :<br>
- do we really need a class to store an Id, even if we want this ID to be constrained ?<br>
</blockquote><div><br>We never needed it.&nbsp; It&#39;s just crap code.<br>&nbsp;</div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
I would rather store the Id as a String, and remove completely the class, as the constraint can be checked when reading the configuration, and that&#39;s it.<br>
</blockquote><div><br>Go for it.<br>&nbsp;</div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
I don&#39;t really think it&#39;s necessary to create new ReplicaId() all over the code, nor calling replicaId.getId() to get the String representing this Id. KISS principle...<br>
</blockquote></div><br>+1<br><br>Alex<br></div>

------=_Part_61355_22026851.1219616781863--