Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 69143 invoked from network); 5 Aug 2008 07:55:21 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 5 Aug 2008 07:55:21 -0000 Received: (qmail 59321 invoked by uid 500); 5 Aug 2008 07:55:20 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 59126 invoked by uid 500); 5 Aug 2008 07:55:20 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 59115 invoked by uid 99); 5 Aug 2008 07:55:20 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Aug 2008 00:55:20 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of elecharny@gmail.com designates 209.85.134.190 as permitted sender) Received: from [209.85.134.190] (HELO mu-out-0910.google.com) (209.85.134.190) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Aug 2008 07:54:22 +0000 Received: by mu-out-0910.google.com with SMTP id g7so1938644muf.5 for ; Tue, 05 Aug 2008 00:54:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:reply-to :user-agent:mime-version:to:subject:content-type :content-transfer-encoding; bh=pBkxHTWVMVylwP0lY4+9khUhoYXurm5fRY41sF52vas=; b=NeonvD2fspfufwJS2dvXrLPcDCmUjeu6B+p69KM0R7uOWFJvYZK9CcSwVPACnkiCoV GAG7m9gXecLGf+yytvKtxzamRNAdf1BLW/XucjjYTP71rtfXaK0pqhg0HVb5veF2SaWK 991Lnh1lo+gqh6zWuLcetdJjVNwfjEuIaUFio= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:reply-to:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; b=eUFJpcVWO8D/ei4gDoqCiksRv/dheovk7tliQ5loZ6a1l9nO/0fCjLXCUQEkGhVzpA h/2z2X2fjq97NS0/2Qbn3ig448Xe6kSvFzSC+Dlm+91tdhDyW6wdYRzOtoNG6h/co1GD ox1koHXIfVTPkxxzC+BrQxwcbkTEkOIo3Qobw= Received: by 10.102.234.18 with SMTP id g18mr399618muh.105.1217922888764; Tue, 05 Aug 2008 00:54:48 -0700 (PDT) Received: from ?192.168.0.2? ( [82.66.216.176]) by mx.google.com with ESMTPS id g1sm23449349muf.7.2008.08.05.00.54.47 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 05 Aug 2008 00:54:47 -0700 (PDT) Message-ID: <48980746.8070002@gmail.com> Date: Tue, 05 Aug 2008 09:54:46 +0200 From: Emmanuel Lecharny Reply-To: elecharny@nextury.com User-Agent: Thunderbird 2.0.0.16 (X11/20080724) MIME-Version: 1.0 To: Apache Directory Developers List Subject: A better organization for tests Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org Hi guys, when I started to work on SASL code, I moved the test into a specific operations.bind package in order to have a clean place to work. Then we discussed with Alex and we found that splitting tests into several packages, one per operation, would be a great thing. Alex started to do that on server integ, and you can see that we have operations.add, operations.del, etc. The good thing about this is that it allows us to get a better operation coverage, as we now have one unique place where we have all the tests about one single operation. There is also something messy about the current tests : we have many DIRSERVER-xxxTest which cover one very specific bug. Having a new regression test for each bug is good, but it might be better to inject those tests into the operation they belongs to. So here is a proposal : what about cleaning the tests, and order all the spreaded tests into the correct package, when we have defined all of them ? Also, I think we have to go through the RFCs and check of we cover all the corner cases for each operations (I'm pretty sure we aren't...) wdyt ? -- -- cordialement, regards, Emmanuel L�charny www.iktek.com directory.apache.org