Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 14445 invoked from network); 13 Aug 2008 10:43:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 13 Aug 2008 10:43:36 -0000 Received: (qmail 8914 invoked by uid 500); 13 Aug 2008 10:43:35 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 8879 invoked by uid 500); 13 Aug 2008 10:43:34 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 8868 invoked by uid 99); 13 Aug 2008 10:43:34 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Aug 2008 03:43:34 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Aug 2008 10:42:46 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 8EB24234C1AB for ; Wed, 13 Aug 2008 03:42:44 -0700 (PDT) Message-ID: <11379304.1218624164583.JavaMail.jira@brutus> Date: Wed, 13 Aug 2008 03:42:44 -0700 (PDT) From: "gerke forcare (JIRA)" To: dev@directory.apache.org Subject: [jira] Commented: (DIRSERVER-1229) KerberosProtocolHandler has server and client swapped in logErrorMessage In-Reply-To: <1211236370.1218623924613.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DIRSERVER-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622162#action_12622162 ] gerke forcare commented on DIRSERVER-1229: ------------------------------------------ I just thought that it might be useful to know that the server and client times (error.getServerTime()/error.getClientTime()) have been swapped. (diff would have shown, but it's hard to see from the code snippets given above. Sorry. > KerberosProtocolHandler has server and client swapped in logErrorMessage > ------------------------------------------------------------------------ > > Key: DIRSERVER-1229 > URL: https://issues.apache.org/jira/browse/DIRSERVER-1229 > Project: Directory ApacheDS > Issue Type: Bug > Components: kerberos > Affects Versions: 1.5.3 > Environment: source-code review > Reporter: gerke forcare > Priority: Minor > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > One can read in the source (org.apache.directory.server.kerberos.protocol.KerberosProtocolHandler logErrorMessage): > sb.append( "Responding to request with error:" ); > sb.append( "\n\t" + "explanatory text: " + error.getExplanatoryText() ); > sb.append( "\n\t" + "error code: " + error.getErrorCode() ); > sb.append( "\n\t" + "clientPrincipal: " + error.getClientPrincipal() ); > sb.append( "\n\t" + "client time: " + error.getServerTime() ); > sb.append( "\n\t" + "serverPrincipal: " + error.getServerPrincipal() ); > sb.append( "\n\t" + "server time: " + error.getClientTime() ); > which might need to read: > sb.append( "Responding to request with error:" ); > sb.append( "\n\t" + "explanatory text: " + error.getExplanatoryText() ); > sb.append( "\n\t" + "error code: " + error.getErrorCode() ); > sb.append( "\n\t" + "clientPrincipal: " + error.getClientPrincipal() ); > sb.append( "\n\t" + "client time: " + error.getClientTime() ); > sb.append( "\n\t" + "serverPrincipal: " + error.getServerPrincipal() ); > sb.append( "\n\t" + "server time: " + error.getServerTime() ); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.