Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 56375 invoked from network); 9 Jul 2008 14:43:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 9 Jul 2008 14:43:53 -0000 Received: (qmail 91079 invoked by uid 500); 9 Jul 2008 14:43:53 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 91036 invoked by uid 500); 9 Jul 2008 14:43:53 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 91025 invoked by uid 99); 9 Jul 2008 14:43:52 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Jul 2008 07:43:52 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Jul 2008 14:43:09 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id CE5D2234C15D for ; Wed, 9 Jul 2008 07:43:31 -0700 (PDT) Message-ID: <214205783.1215614611844.JavaMail.jira@brutus> Date: Wed, 9 Jul 2008 07:43:31 -0700 (PDT) From: "Marc DeXeT (JIRA)" To: dev@directory.apache.org Subject: [jira] Commented: (DIRSERVER-577) Loosen LdapProtocolProvider-ServerLdapContext coupling. In-Reply-To: <523638094.1139911148854.JavaMail.jira@ajax.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DIRSERVER-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612126#action_12612126 ] Marc DeXeT commented on DIRSERVER-577: -------------------------------------- It was a problem ! I have stop my LdapProtocoleProvider based proxy development because of this coupling ! > Loosen LdapProtocolProvider-ServerLdapContext coupling. > ------------------------------------------------------- > > Key: DIRSERVER-577 > URL: https://issues.apache.org/jira/browse/DIRSERVER-577 > Project: Directory ApacheDS > Issue Type: Improvement > Components: ldap > Affects Versions: 1.0-RC1 > Reporter: Marc DeXeT > Priority: Minor > Fix For: 1.5.3 > > > LdapProtocoleProvider is heavely coupled to ServerLdapContext, even the package name has changed to 'server'. > To allow more custom override, I suggest to do 'instanceof' test at least on LdapContext.lookup("") result. > You can see such direct casting into SessionRegistry > /.../ > else if ( ctx != null && allowAnonymous ) > { > ServerLdapContext slc = null; > if ( ! ( ctx instanceof ServerLdapContext ) ) > { > slc = ( ServerLdapContext ) ctx.lookup( "" ); > } > else > { > slc = ( ServerLdapContext ) ctx; > } > /.../ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.