directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Lecharny (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DIRSERVER-577) Loosen LdapProtocolProvider-ServerLdapContext coupling.
Date Wed, 09 Jul 2008 15:07:31 GMT

    [ https://issues.apache.org/jira/browse/DIRSERVER-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612137#action_12612137
] 

Emmanuel Lecharny commented on DIRSERVER-577:
---------------------------------------------

I just meant that it _should_ not be a problem anymore, or if it is, we have to fix the issue.

> Loosen LdapProtocolProvider-ServerLdapContext coupling.
> -------------------------------------------------------
>
>                 Key: DIRSERVER-577
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-577
>             Project: Directory ApacheDS
>          Issue Type: Improvement
>          Components: ldap
>    Affects Versions: 1.0-RC1
>            Reporter: Marc DeXeT
>            Priority: Minor
>             Fix For: 1.5.3
>
>
> LdapProtocoleProvider is heavely coupled to ServerLdapContext, even the package name
has changed to 'server'.
> To allow more custom override, I suggest to do 'instanceof' test at least on LdapContext.lookup("")
result.
> You can see such direct casting into SessionRegistry
> /.../
> else if ( ctx != null && allowAnonymous )
>         {
>             ServerLdapContext slc = null;
>             if ( ! ( ctx instanceof ServerLdapContext ) )
>             {
>                 slc = ( ServerLdapContext ) ctx.lookup( "" );
>             }
>             else
>             {
>                 slc = ( ServerLdapContext ) ctx;
>             }
> /.../

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message