directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Karasulu" <akaras...@apache.org>
Subject Re: [ApacheDS] Modify operation
Date Mon, 16 Jun 2008 18:21:25 GMT
On Mon, Jun 16, 2008 at 8:14 AM, Emmanuel Lecharny <elecharny@apache.org>
wrote:

> Alex Karasulu wrote:
>
>> Anything stopping us from having a getEntry() on ModifyOperationContext
>> which returns ClonedServerEntry.  I'm thinking we can do the modifications
>> on this entry and then the getOriginalEntry() method on it can get the
>> original state of the entry when needed.
>>
>>
> This would save at least 4 lookups ! The entry cloning is just perfect for
> that. I can't tell from the top of my head the implication of this
> modification, but what I can tell is that the Modify operation is really so
> crappy that whatever we do on it will improve it ;)
>
>> This way things like the JNDI provider does not need to calculate earlier
>> state and lookup the present state.  I think this will also help with
>> respect to other aspects of modifications.
>>  WDYT?
>>
>>
> Go for it. I can also do the cleanup of the modify operation, a I have
> spent a hell lot of time to go through it while analysing the performances
> of the server.
>
> It's up to you !
>

Hey sure if you want to work it go for it.  I'll gladly use it once you're
done.  I guess you'll add this and the optimizations to start using this
entry properly in the chain.  You'll probably get some insane boost in
performance.

Alex

Mime
View raw message