Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 81747 invoked from network); 15 May 2008 10:16:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 15 May 2008 10:16:55 -0000 Received: (qmail 31430 invoked by uid 500); 15 May 2008 10:16:56 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 31400 invoked by uid 500); 15 May 2008 10:16:56 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 31389 invoked by uid 99); 15 May 2008 10:16:56 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 May 2008 03:16:56 -0700 X-ASF-Spam-Status: No, hits=2.4 required=10.0 tests=HTML_MESSAGE,SPF_PASS,SUBJECT_FUZZY_TION X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of akarasulu@gmail.com designates 209.85.198.235 as permitted sender) Received: from [209.85.198.235] (HELO rv-out-0506.google.com) (209.85.198.235) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 May 2008 10:16:10 +0000 Received: by rv-out-0506.google.com with SMTP id g37so379762rvb.25 for ; Thu, 15 May 2008 03:16:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:mime-version:content-type:x-google-sender-auth; bh=YH11+RwW4xvi7Pej114SncABOx8LnOOciZ6lUWudzzs=; b=q3wBAF5A8YycXb02uBuMDGgrl46ZnPU/oltM6MeIAJic8y/3vUEVRTq0t83MD38SJz3283yAldrsLFjdBQOuo7+Ro1kpYj/p5QahZ7GGJUdyAQCoqU/G5yEJQGGrC+fSIqo5E9Nh6i9UEf3QldLdTwnNxVIRQeF/kkYfZzm6X/s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:mime-version:content-type:x-google-sender-auth; b=Uw4fmtesRK3CJ28RNKDdTU1nuadQ1LNfM1YGc+cczfiYIG86xJ/PdbPvdIHEP1zEjMqrdeELfrLiip89mtINRY3g4C2+U6FzsW3zs45U9OHKPL9Zp3dWHtokZHiiT5+fuS1gge2Pp0p/aKokpRCWuD0ehGdy9skHj0soCaGlSfU= Received: by 10.141.22.1 with SMTP id z1mr1012948rvi.282.1210846585328; Thu, 15 May 2008 03:16:25 -0700 (PDT) Received: by 10.141.113.13 with HTTP; Thu, 15 May 2008 03:16:25 -0700 (PDT) Message-ID: Date: Thu, 15 May 2008 06:16:25 -0400 From: "Alex Karasulu" Sender: akarasulu@gmail.com To: "Apache Directory Developers List" Subject: Re: svn commit: r656527 - in /directory/apacheds/branches/bigbang: core-avl/src/main/java/org/apache/directory/server/core/avltree/DefaultMarshaller.java jdbm-store/src/main/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmIndex.ja MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_6447_15632687.1210846585399" X-Google-Sender-Auth: a4a0c0bf5bf9f2c3 X-Virus-Checked: Checked by ClamAV on apache.org ------=_Part_6447_15632687.1210846585399 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Shoot svn is down :(. On Thu, May 15, 2008 at 3:21 AM, Felix Knecht wrote: > Hi Alex > > Your loosing information about e.g. the class not found this way. > I'd propose something like > > catch ( ClassNotFoundException e ) > { > throw new IOException( "Could not find class. " + e.getMessage( ) ); > } > > > Regards > Felix > > > > Author: akarasulu >> Date: Thu May 15 00:16:28 2008 >> New Revision: 656527 >> >> URL: http://svn.apache.org/viewvc?rev=656527&view=rev >> Log: >> make it work with jdk 5 >> >> Modified: >> >> directory/apacheds/branches/bigbang/core-avl/src/main/java/org/apache/directory/server/core/avltree/DefaultMarshaller.java >> >> directory/apacheds/branches/bigbang/jdbm-store/src/main/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmIndex.java >> >> Modified: >> directory/apacheds/branches/bigbang/core-avl/src/main/java/org/apache/directory/server/core/avltree/DefaultMarshaller.java >> URL: >> http://svn.apache.org/viewvc/directory/apacheds/branches/bigbang/core-avl/src/main/java/org/apache/directory/server/core/avltree/DefaultMarshaller.java?rev=656527&r1=656526&r2=656527&view=diff >> >> ============================================================================== >> --- >> directory/apacheds/branches/bigbang/core-avl/src/main/java/org/apache/directory/server/core/avltree/DefaultMarshaller.java >> (original) >> +++ >> directory/apacheds/branches/bigbang/core-avl/src/main/java/org/apache/directory/server/core/avltree/DefaultMarshaller.java >> Thu May 15 00:16:28 2008 >> @@ -61,7 +61,7 @@ >> } >> catch ( ClassNotFoundException e ) >> { >> - throw new IOException( "Could not find class", e ); >> + throw new IOException( "Could not find class" ); >> } >> return object; >> >> Modified: >> directory/apacheds/branches/bigbang/jdbm-store/src/main/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmIndex.java >> URL: >> http://svn.apache.org/viewvc/directory/apacheds/branches/bigbang/jdbm-store/src/main/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmIndex.java?rev=656527&r1=656526&r2=656527&view=diff >> >> ============================================================================== >> --- >> directory/apacheds/branches/bigbang/jdbm-store/src/main/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmIndex.java >> (original) >> +++ >> directory/apacheds/branches/bigbang/jdbm-store/src/main/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmIndex.java >> Thu May 15 00:16:28 2008 >> @@ -176,7 +176,7 @@ >> } >> catch ( NamingException e ) >> { >> - throw new IOException( "Failed to find an equality matching >> rule for attribute type", e ); >> + throw new IOException( "Failed to find an equality matching >> rule for attribute type" ); >> } >> /* >> >> >> >> > > ------=_Part_6447_15632687.1210846585399 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Shoot svn is down :(.

On Thu, May 15, 2008 at 3:21 AM, Felix Knecht <felixk@apache.org> wrote:
Hi Alex

Your loosing information about e.g. the class not found this way.
I'd propose something like

catch ( ClassNotFoundException e )
{
  throw new IOException( "Could not find class. " + e.getMessage( ) );
}


Regards
Felix



Author: akarasulu
Date: Thu May 15 00:16:28 2008
New Revision: 656527

URL: http://svn.apache.org/viewvc?rev=656527&view=rev
Log:
make it work with jdk 5

Modified:
   directory/apacheds/branches/bigbang/core-avl/src/main/java/org/apache/directory/server/core/avltree/DefaultMarshaller.java
   directory/apacheds/branches/bigbang/jdbm-store/src/main/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmIndex.java

Modified: directory/apacheds/branches/bigbang/core-avl/src/main/java/org/apache/directory/server/core/avltree/DefaultMarshaller.java
URL: http://svn.apache.org/viewvc/directory/apacheds/branches/bigbang/core-avl/src/main/java/org/apache/directory/server/core/avltree/DefaultMarshaller.java?rev=656527&r1=656526&r2=656527&view=diff
==============================================================================
--- directory/apacheds/branches/bigbang/core-avl/src/main/java/org/apache/directory/server/core/avltree/DefaultMarshaller.java (original)
+++ directory/apacheds/branches/bigbang/core-avl/src/main/java/org/apache/directory/server/core/avltree/DefaultMarshaller.java Thu May 15 00:16:28 2008
@@ -61,7 +61,7 @@
        }
        catch ( ClassNotFoundException e )
        {
-            throw new IOException( "Could not find class", e );
+            throw new IOException( "Could not find class" );
        }
          return object;

Modified: directory/apacheds/branches/bigbang/jdbm-store/src/main/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmIndex.java
URL: http://svn.apache.org/viewvc/directory/apacheds/branches/bigbang/jdbm-store/src/main/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmIndex.java?rev=656527&r1=656526&r2=656527&view=diff
==============================================================================
--- directory/apacheds/branches/bigbang/jdbm-store/src/main/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmIndex.java (original)
+++ directory/apacheds/branches/bigbang/jdbm-store/src/main/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmIndex.java Thu May 15 00:16:28 2008
@@ -176,7 +176,7 @@
        }
        catch ( NamingException e )
        {
-            throw new IOException( "Failed to find an equality matching rule for attribute type", e );
+            throw new IOException( "Failed to find an equality matching rule for attribute type" );
        }
          /*


 


------=_Part_6447_15632687.1210846585399--