directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pierre-Arnaud Marcelot" ...@marcelot.net>
Subject Re: svn commit: r627296 - /directory/studio/branches/studio-maven/pom.xml
Date Wed, 13 Feb 2008 08:53:50 GMT
You're right... Very odd...
Why did i omit the word 'abstract'???

Thanks for fixing this...
And moving to the 9 version of the parent pom.

Pierre-Arnaud

On Feb 13, 2008 9:45 AM, Felix Knecht <felixk@apache.org> wrote:

>
> >
> > It is failing because it's not finding any test to run in the abstract
> > test case classes (which is plain normal... :( ).
> >
> > Your patch works great, but you're right we never know. Maybe there
> > are some important test cases starting with "Abstract"...
> >
> > We could maybe also add a blank test in each abstract test case...
> > (Just to please the plugin).
>
> Silly question, but why is a class named Abstract* not abstract but
> public? Then it would work also!
>
> Index:
>
> /home/felix/svn/apache/directory/studio/branches/studio-maven/studio-dsml-parser/src/test/java/org/apache/directory/studio/dsmlv2/AbstractResponseTest.java
> ===================================================================
> ---
>
> /home/felix/svn/apache/directory/studio/branches/studio-maven/studio-dsml-parser/src/test/java/org/apache/directory/studio/dsmlv2/AbstractResponseTest.java
> (revision 627293)
> +++
>
> /home/felix/svn/apache/directory/studio/branches/studio-maven/studio-dsml-parser/src/test/java/org/apache/directory/studio/dsmlv2/AbstractResponseTest.java
> (working copy)
> @@ -33,7 +33,7 @@
>  * @author <a href="mailto:dev@directory.apache.org">Apache Directory
> Project</a>
>  * @version $Rev$, $Date$
>  */
> -public class AbstractResponseTest extends TestCase
> +public abstract class AbstractResponseTest extends TestCase
>  {
>     /**
>      * Asserts that parsing throws a correct XmlPullParserException due
> to an incorrect file
>
>
> Index:
>
> /home/felix/svn/apache/directory/studio/branches/studio-maven/studio-dsml-parser/src/test/java/org/apache/directory/studio/dsmlv2/AbstractTest.java
> ===================================================================
> ---
>
> /home/felix/svn/apache/directory/studio/branches/studio-maven/studio-dsml-parser/src/test/java/org/apache/directory/studio/dsmlv2/AbstractTest.java
> (revision 627293)
> +++
>
> /home/felix/svn/apache/directory/studio/branches/studio-maven/studio-dsml-parser/src/test/java/org/apache/directory/studio/dsmlv2/AbstractTest.java
> (working copy)
> @@ -33,7 +33,7 @@
>  * @author <a href="mailto:dev@directory.apache.org">Apache Directory
> Project</a>
>  * @version $Rev$, $Date$
>  */
> -public class AbstractTest extends TestCase
> +abstract class AbstractTest extends TestCase
>  {
>     /**
>      * Asserts that parsing throws a correct XmlPullParserException due
> to an incorrect file
>
>
>
>
> Felix
>
>

Mime
View raw message